Assure choices are strings #1395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes problem where the iterator may return different objects, making
choice fail when trying to use string specific methods.
Example:
return '[%s]' % '|'.join(self.choices)
TypeError: sequence item 0: expected str instance, XXX found
Fixes: pallets#591
magiskboy
approved these changes
Oct 8, 2019
hg-pyun
reviewed
Feb 27, 2020
|
Thanks for the PR! I'm not sure if we should convert to strings here. I think as a user I would prefer the error message over the implicit conversion. |
|
The point about raising an error stands, but I'm also not sure I want to add more runtime type checking. Now that Pallets is Python 3.6+, typing should probably be handled by adding annotations throughout the library. |
|
Thanks for looking at this, but at this point other Pallets projects are adding annotations, which I want to prefer over runtime type checking. The docs already call out that all choices must be strings. On that point, this PR allows ints, which will still fail. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem where the iterator may return different objects, making
choice fail when trying to use string specific methods.
Example:
Fixes: #591