Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode #898

Closed
wants to merge 18 commits into from
Closed

Dark Mode #898

wants to merge 18 commits into from

Conversation

nathanyoung
Copy link
Contributor

BREAKING CHANGE: Dark Mode

What type of change is this?

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Updating documentation.
  • Updating deployment/build pipeline.
  • Updating Project Dependencies
  • Improving or adding to Test Coverage

Completeness Checklist

  • TESTS: My changes maintain the baseline required test coverage, as specified by code climate analysis.
  • DOCS: All new component work is covered in that component's Overview docs.
  • DOCS: All new component work is covered in a component Playground.
  • DOCS: All new visual changes or options are covered under relevant components' VisualTests.
  • My code has no linting or typescript compile warnings.
  • My work is tied to a Github issue and satisfies the acceptance criteria (if applicable) of the corresponding issue.

Quality Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

UI Checklist

  • I have conducted visual UAT on my changes/features.
  • My solution works well on desktop, tablet, and mobile browsers.

nathanyoung and others added 17 commits June 12, 2024 17:27
@nathanyoung
BREAKING CHANGE: Dark mode support (#893)
a65e07a 
* wip

* font colors

* BREAKING CHANGE: background, border, font specific colors

BREAKING CHANGE: background, border, font specific colors
BREAKING CHANGE: Spinner variant prop changed to color

* BREAKING CHANGE: ThemeProvider

* feat(RadioGroup): dark mode support

* feat(Accordion): dark mode support

* feat(Tabs): dark mode support

* feat(TabsSlider): dark mode support

* dark mode tokens

* Update FileUpload.tsx

* Update Heading.Playground.stories.tsx

* Update MediaModal.tsx

* feat(Card): dark mode support

* feat(Alert): dark mode support

* feat(TabsSlider): dark mode support

* feat(CategoryFilter): dark mode support

* wip

* checkboxinput

* OptionTile

* update pdt package with new tokens

* fix build

* fix lint

* Update Box.tsx

* checkboxinput

* Update MediaModal.tsx

* Update SelectInputNative.module.scss

* Update Checkbox.module.scss

* Update pull-request.yml

* light mode button background tokens

* light mode button font color tokens

* light mode button border color tokens

* pdt 1.3.0

* SelectInput dark mode fixes

* Badge dark mode

* spec body font

* wip

* remove internal form color tokens

* remove form theming docs

* wip

* Toast dark mode

* Toggle dark mode

* Table dark mode

* remove component design token documentation

* more cleanup

* datepicker dark mode

* pdt 1.4

* Update Theming.stories.mdx
@semantic-release-bot
chore(release): 2.0.0-beta.1 [skip ci]
62931f3 
# [2.0.0-beta.1](v1.0.0...v2.0.0-beta.1) (2024-06-13)

* BREAKING CHANGE: Dark mode support (#893) ([a65e07a](a65e07a)), closes [#893](#893)

### BREAKING CHANGES

* background, border, font specific colors
* background, border, font specific colors
* Spinner variant prop changed to color
* ThemeProvider

* feat(RadioGroup): dark mode support

* feat(Accordion): dark mode support

* feat(Tabs): dark mode support

* feat(TabsSlider): dark mode support

* dark mode tokens

* Update FileUpload.tsx

* Update Heading.Playground.stories.tsx

* Update MediaModal.tsx

* feat(Card): dark mode support

* feat(Alert): dark mode support

* feat(TabsSlider): dark mode support

* feat(CategoryFilter): dark mode support

* wip

* checkboxinput

* OptionTile

* update pdt package with new tokens

* fix build

* fix lint

* Update Box.tsx

* checkboxinput

* Update MediaModal.tsx

* Update SelectInputNative.module.scss

* Update Checkbox.module.scss

* Update pull-request.yml

* light mode button background tokens

* light mode button font color tokens

* light mode button border color tokens

* pdt 1.3.0

* SelectInput dark mode fixes

* Badge dark mode

* spec body font

* wip

* remove internal form color tokens

* remove form theming docs

* wip

* Toast dark mode

* Toggle dark mode

* Table dark mode

* remove component design token documentation

* more cleanup

* datepicker dark mode

* pdt 1.4

* Update Theming.stories.mdx
@nathanyoung
feat: Modal dark mode (#894)
6030206 
* feat: Modal dark mode

* Update Modal.module.scss

* Update Modal.module.scss
@semantic-release-bot
chore(release): 2.0.0-beta.2 [skip ci]
303d436 
# [2.0.0-beta.2](v2.0.0-beta.1...v2.0.0-beta.2) (2024-06-13)

### Features

* Modal dark mode ([#894](#894)) ([6030206](6030206))
@nathanyoung
fix: bump pdt (#895)
eceae11 
* fix: bump pdt

* fix build
@semantic-release-bot
chore(release): 2.0.0-beta.3 [skip ci]
a3694e7 
# [2.0.0-beta.3](v2.0.0-beta.2...v2.0.0-beta.3) (2024-06-14)

### Bug Fixes

* bump pdt ([#895](#895)) ([eceae11](eceae11))
@nathanyoung
fix(Popover): arrowColor background color type
a9a693a
@semantic-release-bot
chore(release): 2.0.0-beta.4 [skip ci]
00766c5 
# [2.0.0-beta.4](v2.0.0-beta.3...v2.0.0-beta.4) (2024-06-14)

### Bug Fixes

* **Popover:** arrowColor background color type ([a9a693a](a9a693a))
@nathanyoung
fix: transparent border color
4eb2663
@semantic-release-bot
chore(release): 2.0.0-beta.5 [skip ci]
98b09fe 
# [2.0.0-beta.5](v2.0.0-beta.4...v2.0.0-beta.5) (2024-06-14)

### Bug Fixes

* transparent border color ([4eb2663](4eb2663))
@nathanyoung
fix(Table): dark mode loading state (#896)
f4ae24c 
* fix(Table): dark mode loading state

* Update Table.module.scss
@semantic-release-bot
chore(release): 2.0.0-beta.6 [skip ci]
e1835a3 
# [2.0.0-beta.6](v2.0.0-beta.5...v2.0.0-beta.6) (2024-06-17)

### Bug Fixes

* **Table:** dark mode loading state ([#896](#896)) ([f4ae24c](f4ae24c))
@nathanyoung
fix: update color documentation
a2c100f
@semantic-release-bot
chore(release): 2.0.0-beta.7 [skip ci]
bfe57bc 
# [2.0.0-beta.7](v2.0.0-beta.6...v2.0.0-beta.7) (2024-07-08)

### Bug Fixes

* update color documentation ([a2c100f](a2c100f))
@nathanyoung
Merge branch 'main' into beta
8996f17
@semantic-release-bot
chore(release): 2.0.0-beta.8 [skip ci]
9f9fdb6 
# [2.0.0-beta.8](v2.0.0-beta.7...v2.0.0-beta.8) (2024-07-09)
@nathanyoung
clean up
141cd4c
codeclimate[bot]
codeclimate bot reviewed Jul 9, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8331 lines exceeds the maximum allowed for the inline comments feature.

codeclimate[bot]
codeclimate bot reviewed Jul 9, 2024
View reviewed changes
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 8329 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Jul 9, 2024

Code Climate has analyzed commit 55e3b94 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.1% (95% is the threshold).

This pull request will bring the total coverage in the repository to 97.9%.

View more on Code Climate.

@nathanyoung nathanyoung closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanyoung @semantic-release-bot