Clean up timefuncs tests, fix nightly due to new errors #1322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pandas_nightly |
Dr-Irv
requested changes
Aug 13, 2025
tests/test_indexes.py
Outdated
Comment on lines
1375
to
1377
| if PD_LTE_23: | ||
| # cannot shift with no freq starting in pandas 3.0.0 | ||
| check(assert_type(ind.shift(1), pd.TimedeltaIndex), pd.TimedeltaIndex) |
There was a problem hiding this comment.
This is a bug in main right now, and there is a PR to fix it, so let's not make this change. See pandas-dev/pandas#62094 and the associated PR. I'm fine to live with nightly broke on this for now given it will get fixed within a few days.
|
I will keep an eye on the PR you mentioned, also quick note I had to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valueSome of the new error names from pandas-dev/pandas#61468.
Nightly run is passing, see https://github.com/pandas-dev/pandas-stubs/actions/runs/16948579852.