BUG: Raise error when filtering HDF5 with tz-aware index (GH#61479) #61482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnushaUKumar
force-pushed
the
fix-hdf-timezone-issue
branch
from
fc87f6d to
00a1f2c
Compare
|
@AnushaUKumar - the linked issue is not about timezones, did you perhaps get the number wrong? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where applying a .select(where=...) query on an HDF5 store with a timezone-aware DatetimeIndex raised a confusing or incorrect error. Since tz-aware filtering isn't currently supported, we now raise a clear ValueError when such filtering is attempted.
What’s included:
-Adds a specific check in select() to detect and error on tz-aware index queries
-Includes a minimal test case reproducing the issue in test_timezone_bug.py
Closes: #61479