Skip to content

Commit

Permalink
Release 1.3.4 (#240)
Browse files Browse the repository at this point in the history
* Update images for lint and test-behat jobs

* Bump yoast/phpunit-polyfills from 1.0.3 to 1.0.4

* Bump dealerdirect/phpcodesniffer-composer-installer from 0.7.2 to 1.0.0 (#229)

Bumps [dealerdirect/phpcodesniffer-composer-installer](https://github.com/Dealerdirect/phpcodesniffer-composer-installer) from 0.7.2 to 1.0.0.
- [Release notes](https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases)
- [Changelog](https://github.com/PHPCSStandards/composer-installer/blob/main/.github_changelog_generator)
- [Commits](PHPCSStandards/composer-installer@v0.7.2...v1.0.0)

---
updated-dependencies:
- dependency-name: dealerdirect/phpcodesniffer-composer-installer
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* [CMSP-79] PHP 8.2 (#232)

* Bump grunt from 1.5.3 to 1.6.1 (#235)

* fix GPL license version (#236)

* Add CMS Platform to CODEOWNERS (#239)

* [BUGS-5809] Add fallback for $session->get_data() (#237)

* fix GPL license version

* add a fallback
if $session is not null but the ->get_data is this creates a PHP warning
It's possible this might escallate to a fatal in PHP 8+
Originally reported in https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/

* exclude short ternaries being disallowed
I fundamentally disagree with the guidance that they are "rarely used
correctly"

* bump version

* update/add changelog

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: John Spellman <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
3 people authored Feb 7, 2023
1 parent 6e83dd3 commit 6afb1d2
Show file tree
Hide file tree
Showing 9 changed files with 92 additions and 102 deletions.
1 change: 1 addition & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* @pantheon-systems/cms-ecosystem
* @pantheon-systems/cms-platform
8 changes: 7 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
**Tags:** comments, sessions
**Requires at least:** 4.7
**Tested up to:** 6.1
**Stable tag:** 1.3.3
**Stable tag:** 1.3.4
**Requires PHP:** 5.4
**License:** GPLv2 or later
**License URI:** http://www.gnu.org/licenses/gpl-2.0.html
Expand Down Expand Up @@ -71,6 +71,12 @@ This mu-plugin will load WP Native PHP Sessions before all other plugins, while

## Changelog ##

### 1.3.4 (February 7, 2023) ###
* Add fallback for $session->get_data() [[#237(https://github.com/pantheon-systems/wp-native-php-sessions/pull/237)]] (reported [on WordPress.org](https://wordpress.org/support/topic/php-warning-session_start-failed-to-read-session-data-user/))
* Update CODEOWNERS file [[#239](https://github.com/pantheon-systems/wp-native-php-sessions/pull/239)]
* Fix GPL license in `composer.json` file [[#236](https://github.com/pantheon-systems/wp-native-php-sessions/pull/236)]
* Bump grunt from 1.5.3 to 1.6.1 [[#235](https://github.com/pantheon-systems/wp-native-php-sessions/pull/235)]

### 1.3.3 (January 25, 2023) ###
* Bump version in pantheon-sessions.php [[#234](https://github.com/pantheon-systems/wp-native-php-sessions/pull/234)].

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "pantheon-systems/wp-native-php-sessions",
"description": "native PHP sessions stored in the database for WordPress.",
"type": "wordpress-plugin",
"license": "GPLv2 or later",
"license": "GPL-2.0-or-later",
"authors": [
{
"name": "Pantheon",
Expand Down
2 changes: 1 addition & 1 deletion inc/class-session-handler.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public function read( $session_id ) {

$session = Session::get_by_sid( $session_id );
if ( $session ) {
return $session->get_data();
return $session->get_data() ?: '';
} else {
return '';
}
Expand Down
Loading

0 comments on commit 6afb1d2

Please sign in to comment.