Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSRV 1.66.0 #445

Conversation

tgonzalezorlandoarm
Copy link
Member

Signed-off-by: Tomás González [email protected]

Copy link
Collaborator

@Superhepper Superhepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Copy link
Contributor

@gowthamsk-arm gowthamsk-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/main-update-msrv-1.66.0 branch 2 times, most recently from b1bcb32 to d359c7e Compare October 5, 2023 10:14
@wiktor-k
Copy link
Collaborator

wiktor-k commented Oct 5, 2023

Hi, it seems the codespell found some issues, I think they are relatively minor and could just be fixed in a follow-up commit. With one exception: it seems AcSend should be spelled like that and maybe it should be added here: https://github.com/parallaxsecond/rust-tss-esapi/blob/main/.codespellrc#L3 (as an exception)

@tgonzalezorlandoarm
Copy link
Member Author

Hi @wiktor-k ! Yes, thanks for noticing. I have opened PR #448 for this, it has one approval already, could I get you to review that one as well ?

Signed-off-by: Tomás González <[email protected]>
MSRV (Minimum Supported Rust Version) is now 1.66.0

 * Remove conditional compilation flags that were valid only when
   versions older than 1.66 were used.

Signed-off-by: Tomás González <[email protected]>
@tgonzalezorlandoarm tgonzalezorlandoarm force-pushed the tg/main-update-msrv-1.66.0 branch from d359c7e to 944c692 Compare October 5, 2023 10:42
@tgonzalezorlandoarm tgonzalezorlandoarm merged commit 979210a into parallaxsecond:main Oct 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants