Improves handling of size_t FFI values.
#471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
force-pushed
the
size_t-handling
branch
4 times, most recently
from
65e1a61 to
4a6e638
Compare
Superhepper
changed the title
size_t FFI values.size_t FFI values.
ionut-arm
reviewed
Nov 10, 2023
Superhepper
force-pushed
the
size_t-handling
branch
3 times, most recently
from
316fc8e to
c163fac
Compare
wiktor-k
previously approved these changes
Nov 16, 2023
|
@wiktor-k |
Superhepper
force-pushed
the
size_t-handling
branch
3 times, most recently
from
38d0b7c to
50f24ac
Compare
ionut-arm
reviewed
Nov 18, 2023
| let mut buffer = vec![0; Self::BUFFER_SIZE]; | ||
| let mut offset = 0; | ||
|
|
||
| fn marshall_offset(&self, marshalled_data: &mut [u8], offset: &mut usize) -> Result<()> { |
There was a problem hiding this comment.
This one doesn't fit the macro patterns?
tss-esapi/src/traits.rs
Outdated
| let mut dest = 0_u32; | ||
| /// Macro used to implement Marshall and Unmarshall for types that | ||
| /// can be converted from native to TSS i.e. it cannot fail and are | ||
| /// passed to MUAPI by value(i.e. pointer). |
There was a problem hiding this comment.
by value (i.e. pointer) - is this correct?
| } | ||
|
|
||
| // Make the macros usable outside of the module. | ||
| pub(crate) use impl_marshall_trait; |
There was a problem hiding this comment.
Is this actually imported somewhere else?
There was a problem hiding this comment.
No, but I thought it could be useful if you for some reason only wanted to implement one of the traits or there was a case where the implementation did not fit the other macros.
And I had some problem getting it to build if I did not export them as well.
- The size_t type that is used in all the MU APIs will be dependent on the compiler that ```bindgen``` uses to generate the bindings for the library. This attempts to make the crate less dependant on that value in the public APIs. - Changes the Marshall and Unmarshall traits to use usize as input. - Removed the ```private_in_public``` it is 'warn by default' and because documentation ci is run with ```-Dwarnings``` it will cause the lint to be enforced. Signed-off-by: Jesper Brynolf <[email protected]>
Superhepper
force-pushed
the
size_t-handling
branch
from
50f24ac to
041d204
Compare
wiktor-k
approved these changes
Nov 20, 2023
hug-dev
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindgenuses to generate the bindings for the library. This attempts to make the crate less dependant on that value in the public APIs.size_tin marshalling and unmarshalling trait implementation. #469