-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PVF: Take back a stolen right #1207
Conversation
After a recent [worker revolt](paritytech/polkadot#7538), they managed to gain a small amount of freedom from the landowner host. But after the failed [proletariat revolution](paritytech/polkadot#7570), there were mass migrations and we ended up in a new repo. The capitalists took advantage of the confusion to secretly take away a workers' right. We must undo this before it goes too far.
See polkadot repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that! I completely forgot about that dependency loop through sp-tracing
🤦♂️
Can you explain? I don't remember the full context of the change, just adding back stuff that was stolen during the migration. |
I like the PR description style 🥇 |
Workers always should have tracing, including in production, it should not be gated behind the `test-utils` feature. Added a note to eventually remove it with a link to the issue.
…ight' into mrcnski/pvf-take-back-a-stolen-right
bot merge |
@mrcnski Unknown command "merge". Refer to help docs and/or source code. |
After a recent worker revolt, the workers managed to gain a small amount of freedom from the landowner host. But after the failed proletariat revolution, there were mass migrations and we ended up in a new repo. The capitalists took advantage of the confusion to secretly take away a workers' right. We must undo this before it goes too far.