-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add notification priority 1 information #174
Conversation
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 93.53% 95.79% +2.25%
==========================================
Files 23 23
Lines 588 832 +244
==========================================
+ Hits 550 797 +247
+ Misses 38 35 -3 ☔ View full report in Codecov by Sentry. |
@mtrezza this is ready for review. |
@@ -191,7 +191,8 @@ Provide one of the following values: | |||
|
|||
* `10` - The push notification is sent to the device immediately. (Default) | |||
> The push notification must trigger an alert, sound, or badge on the device. It is an error to use this priority for a push notification that contains only the `content-available` key. | |||
* `5` - The push message is sent at a time that conserves power on the device receiving it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we repeating the Apple push docs here or is that all specific to the package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is repeating the apple docs. Many of the properties in this doc are repeating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we doing that?
From the APN docs: https://developer.apple.com/documentation/usernotifications/sending-notification-requests-to-apns:
Specify 1 to prioritize the device’s power considerations over all other factors for delivery, and prevent awakening the device.