Skip to content

fix #432: cloud path is not working in Windows due to absolute file path protocol #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix #432: cloud path is not working in Windows due to absolute file path protocol #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4151cb0
fix #432: cloud path is not working in Windows due absolute paths pro…
rjcodedev Jan 10, 2024
47cb964
Merge branch 'master' into master
rjcodedev Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import http from 'http';
export const config = {
databaseURI:
process.env.DATABASE_URI || process.env.MONGODB_URI || 'mongodb://localhost:27017/dev',
cloud: process.env.CLOUD_CODE_MAIN || __dirname + '/cloud/main.js',
cloud: function () {
import('./cloud/main.js');
},
Comment on lines +13 to +15
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would ignore the env var; could you refactor? I think the path can be set in an OS agnostic way, using the url lib, instead of __dirname and for example url.fileURLToPath.

appId: process.env.APP_ID || 'myAppId',
masterKey: process.env.MASTER_KEY || '', //Add your master key here. Keep it secret!
serverURL: process.env.SERVER_URL || 'http://localhost:1337/parse', // Don't forget to change to https if needed
Expand Down