-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add special handling for zero-length arrays to enhance PTA precision #140
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
============================================
+ Coverage 71.91% 71.94% +0.02%
- Complexity 4354 4365 +11
============================================
Files 479 479
Lines 15856 15868 +12
Branches 2175 2179 +4
============================================
+ Hits 11403 11416 +13
- Misses 3571 3573 +2
+ Partials 882 879 -3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very great optimization. Thanks for your work.
I've left some suggestions for improving the clarity of the code. Please give feedback. Finally, don't forget to rerun and update the "*-expected.txt" file.
src/main/java/pascal/taie/analysis/pta/core/heap/AbstractHeapModel.java
Outdated
Show resolved
Hide resolved
src/main/java/pascal/taie/analysis/pta/core/heap/AbstractHeapModel.java
Outdated
Show resolved
Hide resolved
Thanks, @zhangt2333 !
|
revision 2:
|
Signed-off-by: cs-cat <[email protected]>
Maintaining a points-to-set for components of a zero-length array is unnecessary. Use a mock object
ZeroLengthArray
to represent the zero-length array object instead.Some microbenchmarks suggest improvements in both precision and performance.
benchmark result on dacapo-2006:eclipse