Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typing of initial state in EmulatorConfig, fix normalization with qutip 5 #792

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Fix typing of initial state in EmulatorConfig, fix normalization with qutip 5 #792

merged 3 commits into from
Jan 23, 2025

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Jan 21, 2025

Fixes #789 and #791

HGSilveri
HGSilveri reviewed Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it fixed the bug? Also, I think this should be an hotfix

@HGSilveri HGSilveri linked an issue Jan 21, 2025 that may be closed by this pull request
Bug with initial state in Pulser 1.2 #791
Closed
HGSilveri
HGSilveri approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's just turn it into a hotfix instead

@a-corni a-corni changed the base branch from develop to master January 23, 2025 13:41
@HGSilveri
Copy link
Collaborator

You have to rebase this, I think

@a-corni a-corni merged commit 7f91905 into master Jan 23, 2025
10 checks passed
@a-corni a-corni deleted the simu_init_state branch January 23, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HGSilveri HGSilveri HGSilveri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type of initial state is too strict Bug with initial state in Pulser 1.2
2 participants
@a-corni @HGSilveri