ES6 linting and Promises #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linting: Switch from jshint to eslint
- Optimization: Add `use strict` directives
- Docs: Add jsdoc; avoid including command prompt as harder to copy-paste; update references in code to passport-next
- Maintenance: Add `.editorconfig`
- npm: Add recommended fields; fix `licenses`->`license`; update http->https;
simplify script call
- npm: Update chai, mocha
- Linting: As per latest ash-nazg - Travis: Bump Node versions to 10, 12, 14 - Testing: Add `chai-friendly` to auto-allow chai "unused" expressions - npm: Bump engines to 10 - npm: Update devDeps.
- npm: Use nyc in `test` and move non-coverage script to "mocha"
- npm: Update devDeps (including swapping eslint-config-ash-nazg peerDep. and drop need for typescript)
…plugin-markdown` and `eslint-plugin-jsdoc` - npm: Update devDeps.
… text to wiki when ready)
- npm: Update devDeps.
- Testing Check Node 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READ THIS FIRST!
Is this a security patch?
No.
Checklist
$ npm test) executes successfully.$ npm run-script lint) executes successfully.The changes added to UNRELEASED are the following major changes:
enginesto >= 10.0.0This should be blocked by passport-next/passport#21 (and I still intend to try this out in the wild).
In addition to the changes added to UNRELEASED, there are these dev changes (which I believe are new beyond what a recent addition on
masteralready covered); the addition of a test is the one non-maintenance/upkeep type item:chai-friendlyto auto-allow chai "unused" expressions.editorconfigupdate references in code to passport-next
testand move non-coverage script to "mocha"