Skip to content

Fix warnings regarding dependency arrays #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 9, 2025
Merged

Fix warnings regarding dependency arrays #491

merged 3 commits into from
Apr 9, 2025

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Mar 20, 2025

Closes #431

For the inital change I have added the missing dependencies to dependency array.

@patternfly-build
Copy link

patternfly-build commented Mar 20, 2025 •
edited
Loading

Preview: https://chatbot-pr-chatbot-491.surge.sh

A11y report: https://chatbot-pr-chatbot-491-a11y.surge.sh

@rebeccaalpert rebeccaalpert self-requested a review March 20, 2025 21:09
rebeccaalpert
rebeccaalpert requested changes Apr 9, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mash707 - we're out of code freeze. Thanks for the contribution. I pulled this down to test and it looks like some of these changes break some behavior. Would you want to back those and out and we can accept the ones that aren't breaking?

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 9, 2025 •
edited
Loading

@rebeccaalpert Sure I'll look into it, lately I have been busy with the patternfly-react repo.
Will try to make changes asap.

@rebeccaalpert
Copy link
Member

Hi @Mash707 - you can run the code locally here: https://github.com/patternfly/chatbot?tab=readme-ov-file#development.

Compare is at /patternfly-ai/chatbot/overview/demo/comparing-chatbots and feedback is at /patternfly-ai/chatbot/messages/demo.

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 9, 2025

I didn't read the review comments to see what is breaking😅😅, replied in a hurry my bad

@Mash707 Mash707 force-pushed the add-missing-dependencies-to-dependency-array branch from 5340e97 to 5444690 Compare April 9, 2025 18:15
@Mash707 Mash707 requested a review from rebeccaalpert April 9, 2025 18:17
rebeccaalpert
rebeccaalpert approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me; thank you!

@rebeccaalpert rebeccaalpert merged commit ecee998 into patternfly:main Apr 9, 2025
5 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

🎉 This PR is included in version 2.2.0-prerelease.43 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 9, 2025

Thanks @rebeccaalpert for helping out!

@Mash707 Mash707 deleted the add-missing-dependencies-to-dependency-array branch April 9, 2025 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebeccaalpert rebeccaalpert rebeccaalpert approved these changes

@nicolethoen nicolethoen nicolethoen approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

Assignees
No one assigned
Labels
released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing dependencies to dependency arrays
4 participants
@Mash707 @patternfly-build @rebeccaalpert @nicolethoen