Skip to content

feat(ChatBot): Add info density adjustments #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025

Conversation

rebeccaalpert
Copy link
Member

@rebeccaalpert rebeccaalpert commented Apr 3, 2025

This is just the main chatbot demo. Reducing icon size reduced header padding beyond workshop - let me know if you want more padding there.

Docs: https://chatbot-pr-chatbot-513.surge.sh/patternfly-ai/chatbot/overview/demo (see Compact ChatBot)

@rebeccaalpert rebeccaalpert changed the title WIP: feat(ChatBot): Add info density adjustments Draft: feat(ChatBot): Add info density adjustments Apr 3, 2025
@patternfly-build
Copy link

patternfly-build commented Apr 3, 2025

@rebeccaalpert rebeccaalpert force-pushed the density-workshop branch 2 times, most recently from 35fb6ea to d9e36ac Compare April 7, 2025 21:46
@rebeccaalpert rebeccaalpert linked an issue Apr 16, 2025 that may be closed by this pull request
@rebeccaalpert rebeccaalpert force-pushed the density-workshop branch 4 times, most recently from 3a7eeea to 305b572 Compare April 17, 2025 14:02
@rebeccaalpert rebeccaalpert changed the title Draft: feat(ChatBot): Add info density adjustments feat(ChatBot): Add info density adjustments Apr 17, 2025
@kaylachumley kaylachumley self-requested a review April 21, 2025 15:21
Copy link

@kaylachumley kaylachumley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that the history drawer isn't showing the compact version within the compact demo! can we update that?

@rebeccaalpert
Copy link
Member Author

Yup, we just have to wait for the drawer PR to merge!

@rebeccaalpert rebeccaalpert force-pushed the density-workshop branch 2 times, most recently from cb8fa0d to e526177 Compare April 22, 2025 15:08
@rebeccaalpert
Copy link
Member Author

Rebased and added in compact drawer now that that PR has merged.

@rebeccaalpert
Copy link
Member Author

Adjusted drawer close button after comments from Kayla on Slack.

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question

@@ -230,4 +229,14 @@
--pf-v6-c-drawer__head--PaddingInlineStart: var(--pf-t--global--spacer--lg);
--pf-v6-c-drawer__head--PaddingInlineEnd: var(--pf-t--global--spacer--lg);
}
.pf-v6-c-drawer__close {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes properly scoped to being just for the compact variant?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! They are tied to .pf-chatbot__history.pf-m-compact { on line 208.

@nicolethoen nicolethoen merged commit 75e99da into patternfly:main Apr 22, 2025
5 checks passed
Copy link

🎉 This PR is included in version 6.3.0-prerelease.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control information density
6 participants