-
Notifications
You must be signed in to change notification settings - Fork 29
feat(ChatBot): Add info density adjustments #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview: https://chatbot-pr-chatbot-513.surge.sh A11y report: https://chatbot-pr-chatbot-513-a11y.surge.sh |
35fb6ea
to
d9e36ac
Compare
d9e36ac
to
07b2010
Compare
3a7eeea
to
305b572
Compare
305b572
to
8c53af2
Compare
packages/module/patternfly-docs/content/extensions/chatbot/examples/demos/Chatbot.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noticed that the history drawer isn't showing the compact version within the compact demo! can we update that?
Yup, we just have to wait for the drawer PR to merge! |
cb8fa0d
to
e526177
Compare
e526177
to
6bac6f3
Compare
Rebased and added in compact drawer now that that PR has merged. |
4b029e4
to
6fdc5b7
Compare
Adjusted drawer close button after comments from Kayla on Slack. |
6fdc5b7
to
f366bd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question
@@ -230,4 +229,14 @@ | |||
--pf-v6-c-drawer__head--PaddingInlineStart: var(--pf-t--global--spacer--lg); | |||
--pf-v6-c-drawer__head--PaddingInlineEnd: var(--pf-t--global--spacer--lg); | |||
} | |||
.pf-v6-c-drawer__close { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes properly scoped to being just for the compact variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! They are tied to .pf-chatbot__history.pf-m-compact {
on line 208.
🎉 This PR is included in version 6.3.0-prerelease.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is just the main chatbot demo. Reducing icon size reduced header padding beyond workshop - let me know if you want more padding there.
Docs: https://chatbot-pr-chatbot-513.surge.sh/patternfly-ai/chatbot/overview/demo (see Compact ChatBot)