Skip to content

chore(ui): migrate demos from radio to select #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mash707
Copy link
Contributor

@Mash707 Mash707 commented Apr 29, 2025

Closes: #527

@patternfly-build
Copy link

patternfly-build commented Apr 29, 2025

@Mash707
Copy link
Contributor Author

Mash707 commented Apr 29, 2025

@rebeccaalpert I have not converted https://www.patternfly.org/patternfly-ai/chatbot/ui#welcome-message since it has only two options, using select will add more code then reduce. What are your thoughts?
Also I have used if statements, should I use switch instead or do you have an alternate approach?

@rebeccaalpert rebeccaalpert requested a review from edonehoo April 30, 2025 17:36
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great to me. There's a couple areas where we could stand to add <Stack hasGutter> for better spacing. We'll also need to update screenshots, but I can do that after this merges. I pinged Erin for her comments.

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment!

And then this would probably be a separate pr, but it would be nice to stack the checkboxes in https://chatbot-pr-chatbot-540.surge.sh/patternfly-ai/chatbot/ui#header-options, rather than have them in a horizontal list. Just didn't know where else to call this out

@Mash707 Mash707 force-pushed the migrate-ui-demo-from-radio-to-select branch from 14fbabc to 70aea9e Compare May 3, 2025 13:29
@Mash707
Copy link
Contributor Author

Mash707 commented May 3, 2025

Sorry for the delayed response, I have made the necessary changes.

@Mash707
Copy link
Contributor Author

Mash707 commented May 3, 2025

And then this would probably be a separate pr, but it would be nice to stack the checkboxes in https://chatbot-pr-chatbot-540.surge.sh/patternfly-ai/chatbot/ui#header-options, rather than have them in a horizontal list. Just didn't know where else to call this out

We currently have this implementation https://chatbot-pr-chatbot-540.surge.sh/patternfly-ai/chatbot/ui/#drawer-with-search-and-new-chat-button, would be a easy task

@Mash707 Mash707 requested review from edonehoo and rebeccaalpert May 3, 2025 13:34
Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to Rebecca if we want to include the checkbox stacking in this or another PR. But this looks good!

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do the checkboxes separately - I'll update screenshots after this merges.

@rebeccaalpert rebeccaalpert merged commit 52dc5c8 into patternfly:main May 6, 2025
5 checks passed
@Mash707 Mash707 deleted the migrate-ui-demo-from-radio-to-select branch May 12, 2025 10:28
Copy link

🎉 This PR is included in version 6.3.0-prerelease.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert UI demos from using radio to select
4 participants