Replace auto_tool_execution with execute_tools (just first step) #874
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the parameter and context name "auto_tool_execution" with "execute_tools" as the first step toward addressing issue #829.
- Renames parameter and context strings in both the tests and production code.
- Updates inline documentation and code examples in the README.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/langchain/assistant/assistant_spec.rb | Updated context and method calls in tests |
| lib/langchain/assistant.rb | Renamed parameters and methods for tool execution |
| examples/assistant_chat.rb | Updated method calls to use the new naming |
| README.md | Updated documentation to reflect the new naming |
| # @return [Array<Langchain::Message>] The messages | ||
| def run(auto_tool_execution: false) | ||
| def run(execute_tools: false) |
There was a problem hiding this comment.
A simple renaming would introduce a breaking change. A more user-friendly migration would likely be to issue a deprecation warning when the old option name (:auto_tool_execution) is used. Using the new option name (:execute_tools) does not produce any warnings.
According to #829, it also indicates that the default value of these options will change from false to true. It would be best for #829 to deliver this as a single change to users, rather than breaking it into separate steps.
First step of issue #829