fix(ui): show outline on focus for sort column buttons #9557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlessioGr
approved these changes
Jan 17, 2025
|
Hi ok how does this work I'm having difficult time
…On Thu., Jan. 16, 2025, 9:04 p.m. Alessio Gravili, ***@***.***> wrote:
Merged #9557 <#9557> into main.
—
Reply to this email directly, view it on GitHub
<#9557 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BOBG6LKNYZSRO25U2ZH4XOT2LBXNPAVCNFSM6AAAAABSSFP5SKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHE3TAOBXGI4DGNA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
🚀 This is included in version v3.18.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Feb 21, 2025
Fixes #9611. When using the keyboard, focus is invisible when the active element is a sort column button. This change ensures that focus remains visible when the active element is a sort column button.  
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9611.
When using the keyboard, focus is invisible when the active element is a sort column button. This change ensures that focus remains visible when the active element is a sort column button.