Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly resetting io stream to start after pandas read. #53

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bk521234
Copy link
Contributor

@bk521234 bk521234 commented Dec 6, 2020

fixing broken assertion in list item 2 in issue #52 . This wont fix item 1 in #52, but it's a step closer to non-broken tests.

I ran nox and there are 2 broken tests instead of 3 after this update.

Copy link
Contributor

@thomasjohns thomasjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Would it make sense to maintain this invariant "higher up in the code"? E.g. possibly here

yield from visitor_method(node)
after the parse/visit is finished we could do

node._stream.seek(0)

or

node.stream.seek(0)  # where I think the seek method is added to the StreamManager

. I wonder if test_node_stream_property_returns_at_byte_0_after_parse will fail for xlsx too? If so that would be another argument for the "higher up in the code" solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants