Add auto_add_now=True to Wallet.created
#25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pconerly
force-pushed
the
wallet-created-auto-add-now
branch
from
7f945fd to
eb47d15
Compare
|
rebased onto main after |
payton
reviewed
Jun 9, 2022
| account = Account.create() | ||
| wallet = Wallet.objects.create(ethereum_address=account.address) | ||
| diff = wallet.created - now | ||
| self.assertTrue(diff < datetime.timedelta(seconds=1)) |
There was a problem hiding this comment.
Created #30 to eventually replace this logic
payton
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use django's built-in
auto_now_addoption onWallet.created. This helps makes usingWallet.objects.createa little nicer and keeps the same behavior that was probably intended in the project.I added this commit ontop of the "minimal tests" branch, so rebasing might be needed if that branch changes before it's merged.