Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GetFullLineCount() to the Rolodex #320

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

lobocv
Copy link

@lobocv lobocv commented Aug 15, 2024

No description provided.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (c3eb16d) to head (33846c3).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   99.63%   99.64%   +0.01%     
==========================================
  Files         164      164              
  Lines       16608    16597      -11     
==========================================
- Hits        16547    16538       -9     
+ Misses         56       54       -2     
  Partials        5        5              
Flag Coverage Δ
unittests 99.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveshanley
Copy link
Member

Can you bump coverage on this? Much thanks.

@daveshanley
Copy link
Member

Thank you for your contribution!

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Useful. Thank you.

@daveshanley daveshanley merged commit 7eb7079 into pb33f:main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants