feat: add new schema builder methods which allow GC to collect built schemas #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takeyourhatoff
force-pushed
the
peak_schema_build
branch
from
6ad0d0b
to
cd43170
Compare
daveshanley
reviewed
Oct 2, 2024
| @@ -164,6 +164,22 @@ func (sp *SchemaProxy) BuildSchema() (*Schema, error) { | |||
| return schema, er | |||
| } | |||
|
|
|||
| func (sp *SchemaProxy) BuildTempSchema() (*Schema, error) { | |||
There was a problem hiding this comment.
Can you add docs to this method? Just so folks know what it is and why it is there.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 99.65% 99.58% -0.07%
==========================================
Files 164 164
Lines 16674 16687 +13
==========================================
+ Hits 16616 16618 +2
- Misses 53 64 +11
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.