Fixing Broken auth when using UBP_SITEURL #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code removed all url parts but host and path in the UBP_SITEURL conditional in the get_siteurl() method. I've added a property called url_parts that gets assigned parsed url values before the reconstruction of the url. This way the url_parts can be used in the get_auth method without the auth being removed form the UBP_SITEURL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code removed all url parts but host and path in the UBP_SITEURL conditional in the get_siteurl() method. This meant when using UBP_SITEURL with auth, the auth would never get used in the get_auth method.
I've added a property called url_parts that gets assigned parsed url values before the reconstruction of the url. This way the url_parts can be used in the get_auth method without the auth being removed from the UBP_SITEURL. All other url option should continue to work with or without auth.