Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.7 #253

Merged
merged 27 commits into from
May 24, 2024
Merged

1.2.7 #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a820533
version bump
willyfromtheblock Apr 20, 2024
87abc96
Merge branch 'origin/main' into Weblate.
weblate Apr 21, 2024
23d40a6
version bump
willyfromtheblock Apr 20, 2024
734bff6
Merge branch '1.2.7' of https://github.com/peercoin/peercoin_flutter …
willyfromtheblock Apr 21, 2024
7eb2fd4
Merge branch 'main' of https://weblate.ppc.lol/git/peercoin-flutter/t…
willyfromtheblock Apr 21, 2024
428eb52
Bump version to 1.2.7+140 in pubspec.yaml
willyfromtheblock Apr 21, 2024
8a0bef2
version bump
willyfromtheblock Apr 20, 2024
0d5db13
Merge branch '1.2.7' of https://github.com/peercoin/peercoin_flutter …
willyfromtheblock Apr 21, 2024
33aa4ed
chore: Update color scheme in various screens
willyfromtheblock May 16, 2024
59f3ba3
chore: Trim whitespace in address input field
willyfromtheblock May 16, 2024
b319731
chore: Update switch theme colors in app_themes.dart
willyfromtheblock May 16, 2024
d375c39
Changelog
willyfromtheblock May 20, 2024
06db259
skeleton to push sign transaction results into separate confirmation …
willyfromtheblock May 20, 2024
550874b
better argument and prop handling
willyfromtheblock May 20, 2024
7246149
todos
willyfromtheblock May 20, 2024
f04060d
Added translation using Weblate (English (Middle))
GCE1 May 21, 2024
245e66e
chore: Update wallet sign transaction confirmation screen to include …
willyfromtheblock May 24, 2024
c71a9bf
chore: Refactor address_from_asm to generic_address
willyfromtheblock May 24, 2024
4e70461
Refactor signing inputs in wallet_sign_transaction.dart to use index …
willyfromtheblock May 24, 2024
f425a88
feat: Add handling for no signed inputs in WalletSignTransactionConfi…
willyfromtheblock May 24, 2024
73fb56c
Refactor P2TR address handling in generic_address.dart
willyfromtheblock May 24, 2024
dfaa73f
feat: Add transaction input signing status to confirmation screen
willyfromtheblock May 24, 2024
549256a
feat: Improve error handling for signing inputs in WalletSignTransact…
willyfromtheblock May 24, 2024
55d01ab
Refactor generic_address_test.dart to improve error handling for unkn…
willyfromtheblock May 24, 2024
9194b6f
Refactor key_new.dart to improve transaction signing flow
willyfromtheblock May 24, 2024
e311a03
chore: Update CHANGELOG.md with latest release date
willyfromtheblock May 24, 2024
1438cee
Merge branch 'main' of https://weblate.ppc.lol/git/peercoin-flutter/t…
willyfromtheblock May 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
### **1.2.7** (2023-05-24)

- Various bug fixes and improvements related to flutter upgrade
- Improved flow for transaction signing, now with confirmation and more feedback

### **1.2.6** (2023-04-20)

- Improved transaction signing handling and error messages
Expand Down
6 changes: 5 additions & 1 deletion assets/translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -510,5 +510,9 @@
"sign_transaction_step_3_button_alt": "Copy hex to clipboard",
"sign_transaction_step_3_description": "This is your signed transaction hex. You may double tap to copy it to the clipboard.",
"sign_transaction_input_selector_title": "Select which inputs to sign",
"sign_transaction_signing_failed": "Transaction signing failed."
"sign_transaction_signing_failed": "Transaction signing failed.",
"sign_transaction_inputs": "Inputs",
"sign_transaction_confirmation_title": "Please review transaction",
"sign_transaction_confirmation_input_signed": "Signed",
"sign_transaction_confirmation_input_unsigned": "Not signed"
}
1 change: 1 addition & 0 deletions assets/translations/enm.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
6 changes: 3 additions & 3 deletions lib/screens/settings/app_settings_default_wallet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ class _AppSettingsDefaultWalletScreenState
List<Widget> generateDefaultWallets() {
final inkwells = _availableWallets.map((wallet) {
return InkWell(
onTap: () => saveDefaultWallet(wallet.letterCode),
onTap: () => saveDefaultWallet(wallet.name),
child: ListTile(
title: Text(wallet.title),
leading: Radio(
value: wallet.letterCode,
value: wallet.name,
groupValue: _defaultWallet,
onChanged: (dynamic _) => saveDefaultWallet(wallet.letterCode),
onChanged: (dynamic _) => saveDefaultWallet(wallet.name),
),
),
);
Expand Down
3 changes: 0 additions & 3 deletions lib/screens/setup/setup_auth.dart
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,6 @@ class _SetupAuthScreenState extends State<SetupAuthScreen> {
),
),
value: _biometricsAllowed,
activeColor:
Theme.of(context).colorScheme.background,
inactiveThumbColor: Colors.grey,
onChanged: (newState) {
if (_biometricsAvailable == false) {
ScaffoldMessenger.of(context).showSnackBar(
Expand Down
2 changes: 1 addition & 1 deletion lib/screens/setup/setup_create_wallet.dart
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ class _SetupCreateWalletScreenState extends State<SetupCreateWalletScreen> {
),
color: Theme.of(context)
.colorScheme
.background,
.surface,
border: Border.all(
width: 2,
color: _sharedYet
Expand Down
4 changes: 2 additions & 2 deletions lib/screens/setup/setup_import_seed.dart
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class _SetupImportSeedState extends State<SetupImportSeedScreen> {
borderRadius: const BorderRadius.all(
Radius.circular(20),
),
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
border: Border.all(
width: 2,
color: Theme.of(context).primaryColor,
Expand Down Expand Up @@ -223,7 +223,7 @@ class _SetupImportSeedState extends State<SetupImportSeedScreen> {
filled: true,
fillColor: Theme.of(context)
.colorScheme
.background,
.surface,
suffixIcon: IconButton(
onPressed: () async {
final focusScope =
Expand Down
4 changes: 2 additions & 2 deletions lib/screens/setup/setup_landing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class _SetupLandingScreenState extends State<SetupLandingScreen> {
height: MediaQuery.of(context).size.height / 20,
),
Image.asset(
'assets/icon/ppc-icon-white.png',
'assets/icon/ppc-icon-white-256.png',
height: MediaQuery.of(context).size.height / 5,
),
Column(
Expand Down Expand Up @@ -135,7 +135,7 @@ class _SetupLandingScreenState extends State<SetupLandingScreen> {
},
icon: Icon(
Icons.language_rounded,
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
size: 32,
),
),
Expand Down
6 changes: 3 additions & 3 deletions lib/screens/wallet/address_selector.dart
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class _AddressSelectorScreenState extends State<AddressSelectorScreen> {
child: TextFormField(
autofocus: true,
style: TextStyle(
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
),
key: const Key('selectorSearchKey'),
textInputAction: TextInputAction.done,
Expand All @@ -149,15 +149,15 @@ class _AddressSelectorScreenState extends State<AddressSelectorScreen> {
hintText: AppLocalizations.instance
.translate('addressbook_search'),
hintStyle: TextStyle(
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
),
suffixIcon: IconButton(
onPressed: () => setState(() {
_searchActive = false;
}),
icon: Icon(
Icons.close,
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
),
),
),
Expand Down
2 changes: 1 addition & 1 deletion lib/screens/wallet/transaction_details.dart
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ class TransactionDetails extends StatelessWidget {
children: [
DoubleTabToClipboard(
clipBoardData: tx.broadcastHex,
child: Text(
child: SelectableText(
tx.broadcastHex,
),
),
Expand Down
8 changes: 6 additions & 2 deletions lib/screens/wallet/wallet_home.dart
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'package:flutter/material.dart';
import 'package:loader_overlay/loader_overlay.dart';
import 'package:peercoin/data_sources/electrum_backend.dart';
import 'package:peercoin/providers/server_provider.dart';
import 'package:peercoin/screens/wallet/wallet_sign_transaction.dart';
import 'package:peercoin/widgets/wallet/address_book/addresses_tab_watch_only.dart';
import 'package:peercoin/widgets/wallet/wallet_reset_bottom_sheet.dart';
import 'package:provider/provider.dart';
Expand Down Expand Up @@ -465,7 +466,10 @@ class _WalletHomeState extends State<WalletHomeScreen>
case 'transaction_signing':
Navigator.of(context).pushNamed(
Routes.walletTransactionSigning,
arguments: _wallet.name,
arguments: WalletSignTransactionArguments(
walletName: _wallet.name,
coinLetterCode: _wallet.letterCode,
),
);
break;
default:
Expand Down Expand Up @@ -791,7 +795,7 @@ class _WalletHomeState extends State<WalletHomeScreen>
Widget build(BuildContext context) {
return Scaffold(
bottomNavigationBar: _calcBottomNavBar(context),
appBar: _selectedTab == WalletTab.addresses
appBar: _selectedTab == WalletTab.addresses && _wallet.watchOnly
? addressTabWatchOnlySearchAppBar()
: AppBar(
centerTitle: true,
Expand Down
8 changes: 4 additions & 4 deletions lib/screens/wallet/wallet_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ class _WalletListScreenState extends State<WalletListScreen>
borderRadius:
const BorderRadius.all(Radius.circular(50.0)),
border: Border.all(
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
width: 2,
),
),
Expand Down Expand Up @@ -365,7 +365,7 @@ class _WalletListScreenState extends State<WalletListScreen>
style: TextStyle(
letterSpacing: 1.4,
fontSize: 24,
color: Theme.of(context).colorScheme.background,
color: Theme.of(context).colorScheme.surface,
),
),
),
Expand All @@ -386,7 +386,7 @@ class _WalletListScreenState extends State<WalletListScreen>
fontSize: 16,
fontStyle: FontStyle.italic,
color:
Theme.of(context).colorScheme.background,
Theme.of(context).colorScheme.surface,
),
),
if (_importedSeed)
Expand Down Expand Up @@ -438,7 +438,7 @@ class _WalletListScreenState extends State<WalletListScreen>
horizontal: 16,
),
color:
Theme.of(context).colorScheme.background,
Theme.of(context).colorScheme.surface,
child: Column(
children: [
InkWell(
Expand Down
Loading
Loading