Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for ios-objc template #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion templates/modules/ios-objc/Template.m
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ - (NSDictionary *)constantsToExport
// Implement methods that you want to export to the native module
- (void) emitMessageToRN: (NSString *)eventName :(NSDictionary *)params {
// The bridge eventDispatcher is used to send events from native to JS env
// No documentation yet on DeviceEventEmitter: https://github.com/facebook/react-native/issues/2819
// Documentation on DeviceEventEmitter:
// https://facebook.github.io/react-native/docs/native-modules-android.html#sending-events-to-javascript
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointing to the Android documentation instead of iOS.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad 😆 , will update it.

[self sendEventWithName: eventName body: params];
}

Expand Down