Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set command option's like 'EX 1000' and NX failing to parse #3

Closed
eaddingtonwhite opened this issue Dec 20, 2022 · 0 comments · Fixed by #4
Closed

Set command option's like 'EX 1000' and NX failing to parse #3

eaddingtonwhite opened this issue Dec 20, 2022 · 0 comments · Fixed by #4

Comments

@eaddingtonwhite
Copy link
Contributor

When sending a Redis command like
SET foo bar NX EX 1000
or
SET foo2 bar2 EX 1000 NX

against a container running Redis I am able to set this key ok. But when I run it against the proxy code I am seeing the proxy failing to parse the more complex set command and logs the following error:
bad request: bulk string is not a u64
brayniac added a commit to brayniac/pelikan that referenced this issue Dec 20, 2022
@brayniac
bugfix for resp parser
b085eb2 
Fixes pelikan-io#3 by improving the utlity functions which we use to operate
on the array of tokens.

Previously, we were having to track our position in the token
stream but were mixing that with functions which removed tokens
from the stream.

This change makes all the utility functions act by attempting to
take a token from the front of the token stream. This makes the
parser more intuitive to write and less likely to have the same
class of bug.
@brayniac brayniac mentioned this issue Dec 20, 2022
Merged
brayniac added a commit that referenced this issue Dec 20, 2022
@brayniac
bugfix for resp parser (#4)
ddeb75f 
Fixes #3 by improving the utlity functions which we use to operate
on the array of tokens.

Previously, we were having to track our position in the token
stream but were mixing that with functions which removed tokens
from the stream.

This change makes all the utility functions act by attempting to
take a token from the front of the token stream. This makes the
parser more intuitive to write and less likely to have the same
class of bug.
eaddingtonwhite referenced this issue in momentohq/pelikan Dec 29, 2022
@eaddingtonwhite
feat: adds's momento proxy container publish (#3)
2c67ff0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix for resp parser brayniac/pelikan
1 participant
@eaddingtonwhite