bugfix for resp parser #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move rustcommon dependency to pelikan-io fork
Fixes pelikan-io#3 by improving the utlity functions which we use to operate on the array of tokens. Previously, we were having to track our position in the token stream but were mixing that with functions which removed tokens from the stream. This change makes all the utility functions act by attempting to take a token from the front of the token stream. This makes the parser more intuitive to write and less likely to have the same class of bug.
thinkingfish
approved these changes
Dec 20, 2022
|
Hi @brayniac @thinkingfish @kevyang, sorry to ask an irrelevant question on this pr, recently I am testing segcache, and I would like to ask about the eviction policy for segcache, are both ttl and segment size factors that will trigger eviction for cache item? |
|
@luzhang6 - it would be better to ask this question in a new issue since it isn't relevant to this PR. Will be happy to address the question once asked in a new issue. |
|
Thanks, will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3 by improving the utlity functions which we use to operate
on the array of tokens.
Previously, we were having to track our position in the token
stream but were mixing that with functions which removed tokens
from the stream.
This change makes all the utility functions act by attempting to
take a token from the front of the token stream. This makes the
parser more intuitive to write and less likely to have the same
class of bug.