-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field to profile for user to specify type #421
base: master
Are you sure you want to change the base?
Conversation
LGTM! |
We have a degree type on our Major model (link) which can differentiate between undergrad and grad. The user should already be in a group called |
Codecov Report
@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 74.38% 74.33% -0.06%
==========================================
Files 30 30
Lines 5201 5217 +16
==========================================
+ Hits 3869 3878 +9
- Misses 1332 1339 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
{ value: 1, label: 'Masters Student' }, | ||
{ value: 2, label: 'Professional Student' }, | ||
{ value: 3, label: 'Doctoral Student' }, | ||
{ value: 4, label: 'Faculty or Staff Member' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ArmaanT Rerequesting review so I can get your opinion on these labels. Are there better labels that we can use? What is the difference between a masters and a professional student? They generally seem very intertwined when Penn refers to them, would everyone be able to tell which one they should select?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On platform we're using the labels that Penn used to label degrees (link). I'm sure Penn isn't very consistent in their naming, but I think this should be good enough for us. There are definitely conflicts (for example an Accounting MBA is both a Master's and a Professional degree) so we just choose the first label that applies. Bachelor's, then Master's, then PhD, then Professional
The user can specify either undergraduate, graduate, or staff member. Doesn't do much currently, but can be useful for later features if we want to provide relevant members with information tailored to their needs.
Will be good to collect this information early in case we need it later on. There is a detection method, but it is inaccurate and unreliable.
@ArmaanT Not sure how this might interfere with centralized user account information on Platform, so tagging you.