Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field to profile for user to specify type #421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ezwang
Copy link
Member

@ezwang ezwang commented Mar 14, 2021

The user can specify either undergraduate, graduate, or staff member. Doesn't do much currently, but can be useful for later features if we want to provide relevant members with information tailored to their needs.

Will be good to collect this information early in case we need it later on. There is a detection method, but it is inaccurate and unreliable.

image

@ArmaanT Not sure how this might interfere with centralized user account information on Platform, so tagging you.

@ezwang ezwang requested review from ArmaanT and cphalen March 14, 2021 15:04
@cphalen
Copy link
Member

cphalen commented Mar 14, 2021

LGTM!

@ArmaanT
Copy link
Member

ArmaanT commented Mar 14, 2021

We have a degree type on our Major model (link) which can differentiate between undergrad and grad. The user should already be in a group called platform_staff if they're a staff memeber

backend/clubs/models.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #421 (b20d4ff) into master (a9c96a8) will decrease coverage by 0.05%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
- Coverage   74.38%   74.33%   -0.06%     
==========================================
  Files          30       30              
  Lines        5201     5217      +16     
==========================================
+ Hits         3869     3878       +9     
- Misses       1332     1339       +7     
Flag Coverage Δ
backend 74.33% <56.25%> (-0.06%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
backend/clubs/models.py 89.37% <53.33%> (-0.83%) ⬇️
backend/clubs/serializers.py 78.13% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c96a8...b20d4ff. Read the comment docs.

@ezwang ezwang requested a review from ArmaanT April 11, 2021 17:51
{ value: 1, label: 'Masters Student' },
{ value: 2, label: 'Professional Student' },
{ value: 3, label: 'Doctoral Student' },
{ value: 4, label: 'Faculty or Staff Member' },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArmaanT Rerequesting review so I can get your opinion on these labels. Are there better labels that we can use? What is the difference between a masters and a professional student? They generally seem very intertwined when Penn refers to them, would everyone be able to tell which one they should select?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On platform we're using the labels that Penn used to label degrees (link). I'm sure Penn isn't very consistent in their naming, but I think this should be good enough for us. There are definitely conflicts (for example an Accounting MBA is both a Master's and a Professional degree) so we just choose the first label that applies. Bachelor's, then Master's, then PhD, then Professional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants