Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDI-16553] Sort a list of tables fetched from DB. #8954

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[PDI-16553] Sort a list of tables fetched from DB. #8954

wants to merge 6 commits into from
+31 −2

Conversation

ynsamarin
Copy link

@ynsamarin ynsamarin commented Jul 18, 2023 •
edited
Loading

@buildguy

This comment has been minimized.

Sign in to view
@buildguy

This comment has been minimized.

Sign in to view
@ynsamarin
[PDI-16553] Remove a catch block in OtherConnectionDetailsProvider.ge…
39277aa 
…tOpts since FileSystemException is never thrown.
@buildguy

This comment has been minimized.

Sign in to view
@buildguy

This comment has been minimized.

Sign in to view
@hitachivantarasonarqube
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition C Maintainability Rating on New Code (is worse than A)
Failed condition 71.4% 71.4% Coverage on New Code (is less than 80%)

See analysis details on SonarQube

Fix issues before they fail your Quality Gate with SonarLint SonarLint in your IDE.

@smaring smaring requested a review from a team as a code owner October 17, 2023 15:28
@buildguy

This comment has been minimized.

Sign in to view
@buildguy
Copy link
Collaborator

buildguy commented Jul 1, 2024

❌ Build failed in 31m 47s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

⛔ Failed Tests

⛈️ 92 test(s) failed:

org.pentaho.di.core.xml.XMLHandlerUnitTest.addTagValueBinary (click to expand)

expected:<...ytedata>H4sIAAAAAAAA[AA]tJLS5RcEksSQQAL4PL8Q...> but was:<...ytedata>H4sIAAAAAAAA[/w]tJLS5RcEksSQQAL4PL8Q...>

org.pentaho.ui.database.MessagesTest.initializationError (click to expand)

${result.errorDetails}

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.core.attributes.AttributesUtilTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.core.logging.BaseLogTableTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.job.JobTest.executeWithPreviousCheckpointTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.job.JobTest.executeWithPreviousResultsWithRepeatTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.job.JobTest.executeWithPreviousResultsNoRepeatTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.job.entries.deletefiles.JobEntryDeleteFilesTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtPOnPut (click to expand)


Error connecting to host [the.perfect.host]!
Unable to make protected java.net.Socket(java.net.SocketImpl) throws java.net.SocketException accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtPOnPut (click to expand)


Unfinished stubbing detected here:
-> at org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtPOnPut(FTPSConnectionTest.java:81)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, you naughty developer!
 3: you are stubbing the behaviour of another mock inside before 'thenReturn' instruction if completed

org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtP (click to expand)


Error connecting to host [the.perfect.host]!
Unable to make protected java.net.Socket(java.net.SocketImpl) throws java.net.SocketException accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtP (click to expand)


Unfinished stubbing detected here:
-> at org.pentaho.di.job.entries.ftpsget.FTPSConnectionTest.testEnforceProtP(FTPSConnectionTest.java:65)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, you naughty developer!
 3: you are stubbing the behaviour of another mock inside before 'thenReturn' instruction if completed

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.job.entries.job.JobEntryJobTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.job.entries.sftp.SFTPClientTest.shouldIncludeGssapiToPreferredAuthenticationsIfOnlySpecifiedCorrectly (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.testDir (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreationEmptyTest (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.shouldExcludeGssapiFromPreferredAuthenticationsByDefault (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreation_Absolute_Nested (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreation_Relative_Nested (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreation_Absolute_Simple (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreation_Relative_Simple (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.testDirNoFiles (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.folderCreation_Absolute_TrailingSlash (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.shouldIncludeGssapiToPreferredAuthenticationsIfSpecified (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.job.entries.sftp.SFTPClientTest.testReadKeyFile (click to expand)

Unable to make java.net.InetAddress() accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.kitchen.KitchenCommandExecutorTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.pan.PanCommandExecutorTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.StepWithMappingMetaTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.TransMetaTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.TransTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.trans.step.BaseStepTest.testCleanupWithInexistentRemoteSteps (click to expand)

Unable to make protected java.net.ServerSocket(java.net.SocketImpl) accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.pentaho.di.trans.step.BaseStepTest.testCleanup (click to expand)

Unable to make protected java.net.ServerSocket(java.net.SocketImpl) accessible: module java.base does not "opens java.net" to unnamed module @2f410acf

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.csvinput.PDI_15270_Test (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.datagrid.DataGrid_EmptyStringVsNull_Test (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.fieldsplitter.FieldSplitter_EmptyStringVsNull_Test (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.trans.steps.fuzzymatch.FuzzyMatchTest.testProcessRow (click to expand)

Unable to make java.util.HashSet(int,float,boolean) accessible: module java.base does not "opens java.util" to unnamed module @2f410acf

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.groupby.GroupByMetaGetFieldsTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.http.HTTPTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.ifnull.IfNullTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.trans.steps.joinrows.JoinRowsTest.disposeDataFiles (click to expand)

Unable to make private java.io.File(java.lang.String,java.io.File) accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMetaGetFieldsTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.regexeval.RegexEval_EmptyStringVsNull_Test (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.ssh.SSHDataTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.textfileinput.TextFileInputMetaLoadSaveTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.trans.steps.textfileoutput.TextFileOutputTest.testWriteRowToFile_initServletStreamWriter (click to expand)

Unable to make private java.io.PrintWriter(java.nio.charset.Charset,java.io.File) throws java.io.FileNotFoundException accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.trans.steps.textfileoutput.TextFileOutputTest.testWriteRowToFile_initServletStreamWriter (click to expand)


Unfinished stubbing detected here:
-> at org.pentaho.di.trans.steps.textfileoutput.TextFileOutputTest.testWriteRowToFile_initServletStreamWriter(TextFileOutputTest.java:796)

E.g. thenReturn() may be missing.
Examples of correct stubbing:
    when(mock.isOk()).thenReturn(true);
    when(mock.isOk()).thenThrow(exception);
    doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, you naughty developer!
 3: you are stubbing the behaviour of another mock inside before 'thenReturn' instruction if completed

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.userdefinedjavaclass.FieldHelperTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.AllocateServerSocketServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.www.BaseCartePluginTest.testGetService (click to expand)

Unable to make private java.io.PrintWriter(java.nio.charset.Charset,java.io.File) throws java.io.FileNotFoundException accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.www.BaseCartePluginTest.testDoGet (click to expand)

Unable to make private java.io.PrintWriter(java.nio.charset.Charset,java.io.File) throws java.io.FileNotFoundException accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.www.BaseCartePluginTest.testService (click to expand)

Unable to make private java.io.PrintWriter(java.nio.charset.Charset,java.io.File) throws java.io.FileNotFoundException accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.CarteTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.CleanupTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.ExecuteJobServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.ExecuteTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.GetJobImageServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.GetJobStatusServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.GetTransStatusServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.ListServerSocketServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.PauseTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.PrepareExecutionTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.RegisterPackageServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.RemoveJobServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.RemoveTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.SniffStepServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.StartExecutionTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.StartJobServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.StartTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.StopJobServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.www.StopTransServletTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.www.cache.CarteStatusCacheTest.testGet (click to expand)

Unable to make private java.io.File(java.lang.String,java.io.File) accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.www.cache.CarteStatusCacheTest.testPut (click to expand)

Unable to make private java.io.File(java.lang.String,java.io.File) accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.www.cache.CarteStatusCacheTest.testRemove (click to expand)

Unable to make private java.io.File(java.lang.String,java.io.File) accessible: module java.base does not "opens java.io" to unnamed module @2f410acf

org.pentaho.di.trans.steps.jsonoutput.JsonOutputTest.testWriteToFile (click to expand)

Unable to make protected java.io.Writer(java.lang.Object) accessible: module java.base does not "opens java.io" to unnamed module @38cccef

org.pentaho.di.trans.steps.metainject.MetaInjectTest.initializationError (click to expand)

${result.errorDetails}

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.pentahoreporting.PentahoReportingOutputTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.com.pentaho.di.purge.RepositoryCleanupUtilTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.com.pentaho.repository.importexport.PDIImportUtilTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.repository.pur.AttributesMapUtilTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.repository.pur.JobDelegateTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.repository.pur.PurRepositoryStressTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.pentaho.di.ui.repo.timeout.MetaStoreSessionTimeoutHandlerTest.testHandlerCallOnException (click to expand)

Unable to make private java.lang.reflect.Proxy() accessible: module java.base does not "opens java.lang.reflect" to unnamed module @3a4afd8d

org.pentaho.di.ui.repo.timeout.RepositoryServiceSessionTimeoutHandlerTest.testHandlerCallOnException (click to expand)

Unable to make private java.lang.reflect.Proxy() accessible: module java.base does not "opens java.lang.reflect" to unnamed module @3a4afd8d

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.rest.RestTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.trans.steps.s3csvinput.S3CsvInputMetaTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.shapefilereader.ShapeFileReaderTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.core.database.dialog.GetDatabaseInfoProgressDialogTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.core.dialog.EditRowsDialog_EmptyStringVsNull_Test (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.core.widget.ControlSpaceKeyAdapterTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.job.entries.job.JobEntryJobDialogTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.spoon.delegates.SpoonTreeDelegateTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

org.apache.maven.surefire.junit4.JUnit4Provider.org.pentaho.di.ui.trans.steps.fileinput.text.TextFileInputTextCSVImportProgressDialogTest (click to expand)

Internal error: Failed to find the "modifiers" field in method setInternalState.

Tests run: 5020, Failures: 92, Skipped: 13    Test Results

Errors:

Filtered log (click to expand) 

script returned exit code 1

ℹ️ This is an automatic message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ynsamarin @buildguy