PMM-14141 #1107
Open
PMM-14141 #1107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impimp
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
==========================================
- Coverage 70.88% 65.29% -5.60%
==========================================
Files 28 29 +1
Lines 3569 3080 -489
==========================================
- Hits 2530 2011 -519
- Misses 904 929 +25
- Partials 135 140 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi, can you please address linter comments? |
The previous implementation expected this header to be an integer, but vmagent may send it as a float. This caused incorrect handling in `mongodb_exporter`. Updated to support float values.
The exporter was returning cached MongoDB connections without validating their health. This meant that if a connection had become unhealthy, subsequent operations would fail after a delay (serverSelectionTimeout etc), causing the entire request to be slower than it should be. This commit adds `Ping` check before returning a cached client.
Done. |
JiriCtvrtka
approved these changes
Jul 4, 2025
ademidoff
reviewed
Jul 7, 2025
Co-authored-by: Alex Demidoff <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the MongoDB client reconnection logic and refines the Prometheus scrape timeout parsing in the HTTP handler.
- Adds a
Pingcheck before reusing an existing MongoDB client ingetClient. - Switches timeout header parsing from
AtoitoParseFloatand logs invalid values. - Updates the
WithTimeoutcalculation to work with floating‐point seconds and subtracts the configured offset.
Comments suppressed due to low confidence (1)
exporter/exporter.go:309
- [nitpick] The variable name
secondsis generic. Renaming it totimeoutSecondsor similar would improve clarity.
seconds := 10.0
idoqo
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-14141 (optional, if ticket reported)
Below we provide a basic checklist of things that would make it a good PR:
Once all checks pass and the code is ready for review, please add
pmm-review-exportersteam as the reviewer. That would assign people from the review team automatically. Report any issues on our Forum.