PMM-13847 Remove 'user = pmm' and update privilege management #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed 'user = pmm' from supervisord configuration files across various components to align with best practices. Updated privilege escalation mechanisms in Ansible playbooks to ensure proper user context while maintaining functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3811 +/- ##
==========================================
- Coverage 43.87% 43.86% -0.02%
==========================================
Files 367 367
Lines 44627 44620 -7
==========================================
- Hits 19580 19571 -9
- Misses 23363 23366 +3
+ Partials 1684 1683 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Corrected indentation in the initialization playbook task to ensure proper YAML formatting. This fixes potential issues with Ansible processing the task correctly.
Corrected indentation in the initialization playbook task to ensure proper YAML formatting. This fixes potential issues with Ansible processing the task correctly.
Cleaned up obsolete tasks in Ansible files for build optimization, including supervisord initialization and PostgreSQL database cleanup. Configured nginx temporary directories with appropriate permissions to enhance functionality and address potential issues. These changes streamline the build process while ensuring compatibility with updated dependencies.
Set `ignore_errors: True` for supervisord and Grafana log check tasks to prevent playbook failures when logs are unavailable or commands encounter issues. This ensures smoother execution and better fault tolerance during the ansible run.
This commit transitions various configurations and directories from `/etc` to `/srv` for consistency and better organization. It also adjusts file and directory ownership and permissions, simplifying management by removing specific `owner` and `group` settings. These changes streamline directory structure and align with best practices for containerized environments.
Ensure the script handles missing user information by adding default user entry to /etc/passwd when necessary. Also, enforce proper permissions on the PostgreSQL data directory for security and compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 'user = pmm' from supervisord configuration files across various components to align with best practices. Updated privilege escalation mechanisms in Ansible playbooks to ensure proper user context while maintaining functionality.
PMM-13847
Link to the Feature Build: SUBMODULES-3873
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: