Create replication.md quick walkthrough for pg_tde #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started to populate replication with information and added to ToC
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (85.48%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #319 +/- ##
==================================================
Coverage 85.48% 85.48%
==================================================
Files 22 22
Lines 2536 2536
Branches 387 387
==================================================
Hits 2168 2168
Misses 294 294
Partials 74 74
🚀 New features to boost your workflow:
|
Updated text a bit, need to further lint it more PG-802 linked
Replaced master with principal
…na/postgres into DOCS-create-replication.md
Andriciuc
changed the title
dutow
requested changes
May 23, 2025
Initial commit was messy, reworded for basic users and cleared up any confusing parts like heap_tde which was incorrect
nastena1606
temporarily deployed
to
DOCS-create-replication.md - pg-tde-docs PR #319
Render
Destroyed
updated with added -c fast option for pg_basebackup and implemented Zsolt's feedback
dutow
reviewed
Jun 4, 2025
updated based on feedback
dutow
reviewed
Jun 6, 2025
updated with feedback, removed global for configuring key providers, reordered the setup to ensure pg_tde is enabled and THEN create a key, small clarification updates
dutow
reviewed
Jun 6, 2025
| * You have enabled `pg_tde` and you have setup at least one active key on the **primary**. | ||
| * You have configured a global key provider for the **primary**, see [Configure Key Management (KMS)](global-key-provider-configuration/index.md) for more information. | ||
| * You have enabled `pg_tde`. | ||
| * You have configured a key provider for the **primary**, see [Configure Key Management (KMS)](global-key-provider-configuration/index.md) for more information. |
There was a problem hiding this comment.
This assumption still conflicts with later steps - to create a key provider, you have to (1) add pg_tde to the shared preload libraries, and (2) create the extension
Both are later steps.
Same with the "you have enabled pg_tde" - the above 2 steps are the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
started to populate replication with information and added to ToC