-
Notifications
You must be signed in to change notification settings - Fork 9
Reworded the DELETE (previous DROP) key function in Architecture chapter #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworded the DELETE (previous DROP) key function in Architecture chapter #354
Conversation
readded the DELETE key function based on 1257
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #354 +/- ##
==================================================
Coverage 80.49% 80.49%
==================================================
Files 22 22
Lines 2604 2604
Branches 398 398
==================================================
Hits 2096 2096
Misses 430 430
Partials 78 78
🚀 New features to boost your workflow:
|
Reworded the ### Default principal key chapter with a new subtopic Managed a default key and cleaned the wording to make it more visible to the user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this PR? https://perconadev.atlassian.net/browse/PG-1257 is not yet implemented. Documentation should be part of the PR implementing it when it's done.
This branch will be merged into @artemgavrilov's PR implementation once done. Thank you! |
2849a87
to
179f5d7
Compare
1392bd7
into
PG-1257-principal-key-remove-feature
Readded the DELETE key function based on 1257 in Architecture chapter where we also update from DROP to DELETE.