Skip to content

Reworded the DELETE (previous DROP) key function in Architecture chapter #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025

Conversation

Andriciuc
Copy link
Collaborator

Readded the DELETE key function based on 1257 in Architecture chapter where we also update from DROP to DELETE.

readded the DELETE key function based on 1257
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (506606f) to head (b75c1d4).

❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                Coverage Diff                 @@
##           TDE_REL_17_STABLE     #354   +/-   ##
==================================================
  Coverage              80.49%   80.49%           
==================================================
  Files                     22       22           
  Lines                   2604     2604           
  Branches                 398      398           
==================================================
  Hits                    2096     2096           
  Misses                   430      430           
  Partials                  78       78           
Components Coverage Δ
access 82.95% <ø> (ø)
catalog 87.55% <ø> (ø)
common 91.80% <ø> (ø)
encryption 75.47% <ø> (ø)
keyring 72.00% <ø> (ø)
src 66.74% <ø> (ø)
smgr 97.27% <ø> (ø)
transam ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Reworded the ### Default principal key chapter with a new subtopic Managed a default key and cleaned the wording to make it more visible to the user
@nastena1606 nastena1606 temporarily deployed to DOCS-1257-update - INTERNAL-pg_tde docs PR #354 May 26, 2025 13:29 — with Render Destroyed
@nastena1606 nastena1606 temporarily deployed to DOCS-1257-update - pg-tde-docs PR #354 May 26, 2025 13:29 — with Render Destroyed
@Andriciuc Andriciuc marked this pull request as ready for review May 26, 2025 13:32
@Andriciuc Andriciuc requested a review from nastena1606 as a code owner May 26, 2025 13:32
Copy link
Collaborator

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this PR? https://perconadev.atlassian.net/browse/PG-1257 is not yet implemented. Documentation should be part of the PR implementing it when it's done.

@Andriciuc
Copy link
Collaborator Author

What's the reason for this PR? https://perconadev.atlassian.net/browse/PG-1257 is not yet implemented. Documentation should be part of the PR implementing it when it's done.

This branch will be merged into @artemgavrilov's PR implementation once done. Thank you!

@artemgavrilov artemgavrilov changed the base branch from TDE_REL_17_STABLE to PG-1257-principal-key-remove-feature May 28, 2025 15:18
@artemgavrilov artemgavrilov force-pushed the PG-1257-principal-key-remove-feature branch 2 times, most recently from 2849a87 to 179f5d7 Compare May 28, 2025 15:49
@artemgavrilov artemgavrilov merged commit 1392bd7 into PG-1257-principal-key-remove-feature May 28, 2025
15 of 16 checks passed
@artemgavrilov artemgavrilov deleted the DOCS-1257-update branch May 28, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants