Skip to content

Stop coalescing NULL to empty string in key provider functions #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

jeltz
Copy link
Collaborator

@jeltz jeltz commented May 26, 2025

Since we can pass NULL values in the functions which takes JSON it makes no sense to not do so in the functions which take text. By doing this we only risk not excercising some code paths.

Since we can pass NULL values in the functions which takes JSON it makes
no sense to not do so in the functions which take text. By doing this we
only risk not excercising some code paths.
@jeltz jeltz requested review from dutow and dAdAbird as code owners May 26, 2025 13:59
@AndersAstrand
Copy link
Collaborator

AndersAstrand commented May 26, 2025

Does anyone involved when these were added remember why it was done? I'm all for removing them unless we have really good reasons to have them, as they might hide bugs

Copy link
Collaborator

@dutow dutow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add some testcases that uses nulls with this?

If I remember correctly the original json parser accepted empty strings, but reported an error on nulls, which wasn't ideal for optional parameters such as a CA file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants