Skip to content

Tidy sanitizers' suppressions list and fix some mem leaks #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: TDE_REL_17_STABLE
Choose a base branch
from

Conversation

dAdAbird
Copy link
Member

@dAdAbird dAdAbird commented Jun 17, 2025

Tihs PR makes a suppression list as specific as possible, so it won't cover up new issues. And adds comments to existing suppressions. Also, fixes memory leaks in bin/pgctl code (all related to frontend usage) and low-hanging fruits in pgctl.

@dAdAbird dAdAbird requested a review from dutow as a code owner June 17, 2025 14:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

Attention: Patch coverage is 89.36170% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (TDE_REL_17_STABLE@34e2d29). Learn more about missing BASE report.
Report is 14 commits behind head on TDE_REL_17_STABLE.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             TDE_REL_17_STABLE     #438   +/-   ##
====================================================
  Coverage                     ?   84.73%           
====================================================
  Files                        ?       21           
  Lines                        ?     2634           
  Branches                     ?      413           
====================================================
  Hits                         ?     2232           
  Misses                       ?      321           
  Partials                     ?       81           
Components Coverage Δ
access 81.11% <ø> (?)
catalog 88.21% <88.09%> (?)
common 77.77% <ø> (?)
encryption 73.45% <ø> (?)
keyring 72.94% <100.00%> (?)
src 91.46% <100.00%> (?)
smgr 94.88% <ø> (?)
transam ∅ <ø> (?)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dAdAbird dAdAbird force-pushed the cio-cio-asan branch 6 times, most recently from 3c5511d to e8c9ac0 Compare June 17, 2025 16:55
@dAdAbird dAdAbird marked this pull request as draft June 17, 2025 18:39
@dAdAbird dAdAbird marked this pull request as draft June 17, 2025 18:39
@dAdAbird dAdAbird marked this pull request as draft June 17, 2025 18:39
@dAdAbird dAdAbird marked this pull request as ready for review June 18, 2025 12:14
Copy link
Collaborator

@jeltz jeltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have an opinion about the main patch yet but saw two things.

Tihs PR makes a suppression list as specific as possible, so it won't
cover up new issues. And adds comments to existing suppressions.
Also, fixes memory leaks in pg_tde code (all related to frontend usage).
@dAdAbird dAdAbird requested a review from jeltz June 19, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants