forked from postgres/postgres
-
Notifications
You must be signed in to change notification settings - Fork 10
Updated principal-key/features/functions.md based on AA feedback #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andriciuc
wants to merge
6
commits into
release-17.5.2
Choose a base branch
from
fixes-for-features-functions-setprincikey
base: release-17.5.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updated principal-key/features/functions.md based on AA feedback #441
Andriciuc
wants to merge
6
commits into
release-17.5.2
from
fixes-for-features-functions-setprincikey
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In set-principal-key.md: * updated with correct code example using set_server_key_using_global parameter * updated note to reflect correct config In features.md: * Removed temporary tables feature to clear confusion, removed logical replication mention, removed WAL encryption as a feature. In functions.md: * Added ON FUNCTION for grant/revoke execution * Modified sensitive info bolded paragraph to important note * Small modifications to notes display, title cases and text fixes * added note to Add or modify Vault providers for keeping the same principal key. * Added warning for WAL in pg_tde_create_key_using_global_key_provider In general: * Removed all logical replication mentions except the FAQ and in RC2 release note.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-17.5.2 #441 +/- ##
=================================================
Coverage ? 84.68%
=================================================
Files ? 21
Lines ? 2593
Branches ? 401
=================================================
Hits ? 2196
Misses ? 316
Partials ? 81
🚀 New features to boost your workflow:
|
* fixed keyfile to key file and keyfile proviers to key file providers * updated remote config options to file paths for specific param warning note.
fixed keyfile to key file for title Removed warning notes regarding remote config options.
restructured and improved paragraphs create key and creates keys
Added * Temporary tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In set-principal-key.md:
In features.md:
In functions.md:
In general: