fix: cleaned up modal classes logic

perimetre · Apr 6, 2023 · 12d9241 · 12d9241
1 parent 32006fc
commit 12d9241
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -31,6 +31,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Changed modal `new` variant to use UI as updated designs
 
+### Fixed
+
+- Cleaned up modal classes logic
+
 ## [9.3.1] 2023-03-14
 
 ### Changes

diff --git a/src/components/Modal/index.tsx b/src/components/Modal/index.tsx
@@ -110,10 +110,8 @@ export const Modal: React.FC<PropsWithChildren<ModalProps>> = ({
 
   return (
     <ReactPortal selector="#modal-root">
-      <div className={classnames('pui-modal', { open: isOpen }, { new: variant === 'new' })}>
-        <div
-          className={classnames('pui-modal-container', { new: variant === 'new' }, { center: position === 'center' })}
-        >
+      <div className={classnames('pui-modal', { open: isOpen, new: variant === 'new' })}>
+        <div className={classnames('pui-modal-container', { new: variant === 'new', center: position === 'center' })}>
           <div className={classnames('pui-modal-header ', { 'absolute z-30': isHeaderAbsolute })}>
             <h3 className={classnames(removePadding ? 'p-0' : 'p-4')}>{title}</h3>
             {/* Adds a close icon */}