Add version parameter to Perses-CI + add test #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to come around a misleading situation today: e.g with such piece of config in perses/perses repo:
Since
ref
in Perses-CI here was hardcoded to v0.5.2, then this version was the actual one used to retrieve the actions code, not v0.6.0.So with this change the same config would be instead:
And you'd really get the v0.6.0 version of perses/github-actions's actions this time.
NB: actually, by the book, to be resilient to breaking changes made to Perses-CI we should still provide a version number in the
uses
clause, so maybe here:Feels redundant but the 2 versions are actually used for different things 😅