Resubmit tests #16
Open
Resubmit tests #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteli3
requested changes
Apr 26, 2019
| default_action = inc; | ||
| } | ||
|
|
||
| table debug { |
There was a problem hiding this comment.
lets remove debug tbl for the actual test.
|
|
||
| apply { | ||
| t.apply(); | ||
| debug.apply(); |
There was a problem hiding this comment.
remove this pls for when we submit
| in empty_metadata_t clone_i2e_meta, | ||
| in empty_metadata_t clone_e2e_meta) | ||
| { | ||
| state start { |
There was a problem hiding this comment.
right before transition accept;, we need to add a buffer.extract(hdr.ethernet);
| @@ -0,0 +1,3 @@ | |||
| # This packet should be resubmit four times | |||
There was a problem hiding this comment.
can we also add an edge case that should resubmit zero times?
|
@kevinye2
|
derek-so
requested changes
Apr 26, 2019
| } | ||
| table t { | ||
| actions = { inc; | ||
| } |
There was a problem hiding this comment.
They really care about style, can you change this to { inc; } thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this out?