fix: Default to fetching all metrics

petsinc · Dec 16, 2024 · a577d51 · a577d51
1 parent ad8a9e0
commit a577d51
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/basic/metrics.go b/basic/metrics.go
@@ -95,7 +95,6 @@ var Metrics = []Metric{
 		cwName:         "DatabaseConnections",
 		prometheusName: "aws_rds_database_connections",
 		prometheusHelp: "The number of database connections in use. Units: Count",
-		statistics:     []string{"Sum", "Average"},
 	},
 	{
 		cwName:         "Deadlocks",

diff --git a/basic/scraper.go b/basic/scraper.go
@@ -96,10 +96,10 @@ func (s *Scraper) scrapeMetric(metric Metric) error {
 	now := time.Now()
 	end := now.Add(-Delay)
 
-	// If metric.statistics is empty, default to ["Average"] for backwards compatibility
+	// If metric.statistics is empty, default to all
 	stats := metric.statistics
 	if stats == nil || len(stats) == 0 {
-		stats = []string{"Average"}
+		stats = []string{"Average", "Sum", "Minimum", "Maximum"}
 	}
 
 	params := &cloudwatch.GetMetricStatisticsInput{