more defaults cleanup

petsinc · Aug 1, 2024 · b6230ac · b6230ac
1 parent dea2c52
commit b6230ac
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/provider/provider/internal/provider/fqdn_connection_resource.go b/provider/provider/internal/provider/fqdn_connection_resource.go
@@ -359,7 +359,7 @@ func (r *FQDNConnectionResource) Schema(ctx context.Context, req resource.Schema
 					map[string]attr.Value{
 						"ani_override":              types.StringValue("+12345678901"),
 						"ani_override_type":         types.StringValue("always"),
-						"call_parking_enabled":      types.BoolValue(true),
+						"call_parking_enabled":      types.BoolValue(false),
 						"channel_limit":             types.Int64Value(10),
 						"generate_ringback_tone":    types.BoolValue(true),
 						"instant_ringback_enabled":  types.BoolValue(false),

diff --git a/provider/provider/internal/provider/number_order_resource.go b/provider/provider/internal/provider/number_order_resource.go
@@ -91,8 +91,8 @@ func (r *NumberOrderResource) Schema(ctx context.Context, req resource.SchemaReq
 			},
 			"messaging_profile_id": schema.StringAttribute{
 				Description: "Messaging profile ID associated with the number order",
-				Required:    false,
-				Computed:    true,
+				Optional:    true,
+				Computed:	 true,
 				Default:     stringdefault.StaticString(""),
 			},
 			"billing_group_id": schema.StringAttribute{

diff --git a/provider/provider/internal/provider/provider_test.go b/provider/provider/internal/provider/provider_test.go
@@ -272,9 +272,10 @@ func getOptionalNumberOrderConfig() string {
 	if includeNumberOrder {
 		return `
 resource "telnyx_number_order" "this" {
-  connection_id      = telnyx_texml_application.test.id
-  billing_group_id   = telnyx_billing_group.test.id
-  customer_reference = "terraform-test-api-number"
+  connection_id       = telnyx_texml_application.test.id
+  billing_group_id    = telnyx_billing_group.test.id
+  customer_reference  = "terraform-test-api-number"
+  messaging_profile_id = telnyx_messaging_profile.test.id
   phone_numbers = [
     {
       phone_number = telnyx_phone_number_lookup.test.phone_numbers[0].phone_number