improve error handling robustness for os.execvpe

see: pexpect/pexpect#512
pexpect · Jul 2, 2018 · 3399dd7 · 3399dd7
1 parent 5436e55
commit 3399dd7
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/ptyprocess/ptyprocess.py b/ptyprocess/ptyprocess.py
@@ -283,10 +283,14 @@ def spawn(
                     os.execv(command, argv)
                 else:
                     os.execvpe(command, argv, env)
-            except OSError as err:
+            except Exception as err:
                 # [issue #119] 5. If exec fails, the child writes the error
                 # code back to the parent using the pipe, then exits.
-                tosend = 'OSError:{}:{}'.format(err.errno, str(err))
+                if isinstance(err, OSError):
+                    tosend = 'OSError:{}:{}'.format(err.errno, str(err))
+                else:
+                    cls_name = err.__class__.__name__
+                    tosend = 'Exception:0:{}: {}'.format(cls_name, str(err))
                 if PY3:
                     tosend = tosend.encode('utf-8')
                 os.write(exec_err_pipe_write, tosend)