-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check process status for non-child process #39
Open
masteret
wants to merge
4
commits into
pexpect:master
Choose a base branch
from
masteret:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−8
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -699,10 +699,76 @@ def isalive(self): | |
except OSError as e: | ||
# No child processes | ||
if e.errno == errno.ECHILD: | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where "terminated" is 0, but there was no child ' + | ||
'process. Did someone else call waitpid() ' + | ||
'on our process?') | ||
try: | ||
""" | ||
The following code is adopted from psutil with slight modification | ||
|
||
https://github.com/giampaolo/psutil/blob/master/LICENSE | ||
psutil is distributed under BSD license reproduced below. | ||
|
||
Copyright (c) 2009, Jay Loden, Dave Daeschler, Giampaolo Rodola' | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without modification, | ||
are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright notice, this | ||
list of conditions and the following disclaimer. | ||
* Redistributions in binary form must reproduce the above copyright notice, | ||
this list of conditions and the following disclaimer in the documentation | ||
and/or other materials provided with the distribution. | ||
* Neither the name of the psutil authors nor the names of its contributors | ||
may be used to endorse or promote products derived from this software without | ||
specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR | ||
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON | ||
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
""" | ||
os.kill(self.pid, 0) | ||
if sys.platform.startswith("linux"): | ||
with open("/proc/%s/stat" % (self.pid), "rb") as f: | ||
data = f.read() | ||
rpar = data.rfind(b')') | ||
name = data[data.find(b'(') + 1:rpar] | ||
fields_after_name = data[rpar + 2:].split() | ||
if fields_after_name[0] == "Z": | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where the child process becomes a zombie process.' + | ||
' Does other process kill the ptyprocess?') | ||
elif sys.platform.startswith("darwin"): | ||
pass | ||
elif sys.platform.startswith("freebsd"): | ||
pass | ||
else: | ||
pass | ||
""" | ||
The adoption of psutil code ends here | ||
""" | ||
except OSError as err: | ||
if err.errno == errno.ESRCH: | ||
# No such process | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where "terminated" is 0, but there was no child ' + | ||
'process. Did someone else call waitpid() ' + | ||
'on our process?') | ||
elif err.errno == errno.EPERM: | ||
# Process deny access | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where the child process deny access') | ||
else: | ||
# Other possible error | ||
raise err | ||
else: | ||
# Process exists not as child | ||
pid, status = 0, 0 | ||
else: | ||
raise | ||
|
||
|
@@ -717,10 +783,73 @@ def isalive(self): | |
except OSError as e: # pragma: no cover | ||
# This should never happen... | ||
if e.errno == errno.ECHILD: | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'that should never happen. There was no child ' + | ||
'process. Did someone else call waitpid() ' + | ||
'on our process?') | ||
try: | ||
""" | ||
The following code is adopted from psutil with slight modification | ||
|
||
https://github.com/giampaolo/psutil/blob/master/LICENSE | ||
psutil is distributed under BSD license reproduced below. | ||
|
||
Copyright (c) 2009, Jay Loden, Dave Daeschler, Giampaolo Rodola' | ||
All rights reserved. | ||
|
||
Redistribution and use in source and binary forms, with or without modification, | ||
are permitted provided that the following conditions are met: | ||
|
||
* Redistributions of source code must retain the above copyright notice, this | ||
list of conditions and the following disclaimer. | ||
* Redistributions in binary form must reproduce the above copyright notice, | ||
this list of conditions and the following disclaimer in the documentation | ||
and/or other materials provided with the distribution. | ||
* Neither the name of the psutil authors nor the names of its contributors | ||
may be used to endorse or promote products derived from this software without | ||
specific prior written permission. | ||
|
||
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND | ||
ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED | ||
WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR | ||
ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES | ||
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON | ||
ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS | ||
SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
""" | ||
os.kill(self.pid, 0) | ||
if sys.platform.startswith("linux"): | ||
with open("/proc/%s/stat" % (self.pid), "rb") as f: | ||
data = f.read() | ||
rpar = data.rfind(b')') | ||
name = data[data.find(b'(') + 1:rpar] | ||
fields_after_name = data[rpar + 2:].split() | ||
if fields_after_name[0] == "Z": | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where the child process becomes a zombie process.' + | ||
' Does other process kill the ptyprocess?') | ||
elif sys.platform.startswith("darwin"): | ||
pass | ||
elif sys.platform.startswith("freebsd"): | ||
pass | ||
else: | ||
pass | ||
except OSError as err: | ||
if err.errno == errno.ESRCH: | ||
# No such process | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where "terminated" is 0, but there was no child ' + | ||
'process. Did someone else call waitpid() ' + | ||
'on our process?') | ||
elif err.errno == errno.EPERM: | ||
# Process deny access | ||
raise PtyProcessError('isalive() encountered condition ' + | ||
'where the child process deny access') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe
|
||
else: | ||
# Other possible error | ||
raise err | ||
else: | ||
# Process exists not as child | ||
pid, status = 0, 0 | ||
else: | ||
raise | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe