fix: random_page_cost and effective_io_concurrency

added rules to compute those params.

Signed-off-by: Sebastian Webber <[email protected]>

pkg/rules/compute.go

@@ -13,6 +13,7 @@ var allRules = []rule{
 	computeArch,
 	computeOS,
 	computeProfile,
+	computeStorage,
 
 	// computeVersion can remove values deppending on the version
 	// to be sure that it will not break other rules, leave it at

pkg/rules/storage.go

@@ -0,0 +1,24 @@
+package rules
+
+import (
+	"github.com/pgconfig/api/pkg/category"
+	"github.com/pgconfig/api/pkg/config"
+)
+
+func computeStorage(in *config.Input, cfg *category.ExportCfg) (*category.ExportCfg, error) {
+
+	switch in.DiskType {
+	case "SSD":
+		cfg.Storage.EffectiveIOConcurrency = 200
+	case "SAN":
+		cfg.Storage.EffectiveIOConcurrency = 300
+	default:
+		cfg.Storage.EffectiveIOConcurrency = 2
+	}
+
+	if in.DiskType != "HDD" {
+		cfg.Storage.RandomPageCost = 1.1
+	}
+
+	return cfg, nil
+}

pkg/rules/storage_test.go

@@ -0,0 +1,29 @@
+package rules
+
+import (
+	"testing"
+
+	"github.com/pgconfig/api/pkg/category"
+)
+
+func Test_computeStorage(t *testing.T) {
+	in := fakeInput()
+	in.DiskType = "SSD"
+	outSSD, _ := computeStorage(in, category.NewExportCfg(*in))
+	in.DiskType = "SAN"
+	outSAN, _ := computeStorage(in, category.NewExportCfg(*in))
+	in.DiskType = "HDD"
+	outHDD, _ := computeStorage(in, category.NewExportCfg(*in))
+
+	if outSSD.Storage.RandomPageCost > 1.1 || outSAN.Storage.RandomPageCost > 1.1 {
+		t.Error("should use lower values for random_page_cost on both SSD and SAN")
+	}
+
+	if outSSD.Storage.EffectiveIOConcurrency < 200 || outSAN.Storage.EffectiveIOConcurrency < 300 {
+		t.Error("should use higher values for effective_io_concurrency on both SSD and SAN")
+	}
+
+	if outHDD.Storage.EffectiveIOConcurrency > 2 {
+		t.Error("should use lower values for effective_io_concurrency on HDD drives")
+	}
+}

rules.yml

@@ -126,4 +126,4 @@ categories:
         elsif disk_type == "SSD":
           200
         elsif disk_type == "SAN":
-          200
+          300