Try to execute release tests last #17783
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I already tried in the past but this broke the bootstrap in a weird way. Here I'm trying again to see if the problem persist
jecisc
added
the
Status: Need more work
jecisc
added a commit
to jecisc/pharo
that referenced
this pull request
Feb 8, 2025
I'm improving the cleanup of this test because it was leaving an unpackaged class (TestClass) and this subclass was causing its superclass (PoPouet) to end up as an Obsolete Problem detected while working on pharo-project#17783
jecisc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already tried in the past but this broke the bootstrap in a weird way. Here I'm trying again to see if the problem persist
We have a lot of tests in Pharo and it might happen that some of them do not respect the principle of letting the system clean with their tearDown. To help to spot those impacts, I propose to run the releases tests last. Like this, if some bad generated code/or modifications of system entities happens, we might catch it with the verifications of release tests.
I expect this commit to break the tests in the CI but it'll help me find the culprits and fix them.
Redo of #13349