Skip to content

Changes for Cavrois before release #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2025

Conversation

AlexisCnockaert
Copy link
Contributor

@AlexisCnockaert AlexisCnockaert commented Apr 25, 2025

  • Firstly removed CavNullStrategy, had no purpose for the user, removed its test class as well
  • Don't hide the visual placeholders when removal of one, its less redundant for the user
  • Corrected the name when loading a profile (before it was profile name (Current) (Current), kind of bad )
  • Inform the user in case he wants to save a profile when he has none
  • Removed CavVisualPlaceHolderMorph reference from the placeholders because there was a serialization bug with STON
  • New condition for rename in case the user cancels the action
  • Created makeProfileCurrent: so the user can load a default profile in his startUp preferences file in a very simple way
    @Ducasse looks good ?

@Ducasse Ducasse merged commit 12f26d9 into pharo-spec:Pharo13 May 14, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants