Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design before redeploy from main #473

Open
arouinfar opened this issue Jan 14, 2021 · 10 comments
Open

Update design before redeploy from main #473

arouinfar opened this issue Jan 14, 2021 · 10 comments

Comments

@arouinfar
Copy link

Many of the design decisions in Energy Skate Park have affected Energy Skate Park: Basics. Basics was not republished off of master in conjunction with ESP. Before this sim gets republished, we will need to review the current design of ESPB and decide which ESP-only features we would like to add (e.g. skater choice).

@arouinfar arouinfar self-assigned this Jan 14, 2021
@arouinfar
Copy link
Author

This issue blocks #411

@arouinfar
Copy link
Author

arouinfar commented Jun 22, 2022

Summary of the differences:

  • Bar Graph UI (checkbox in control panel vs. AccordionBox)
  • Grid checkbox location (control panel vs. ground)
  • Order of checkboxes in the control panel (Speed before or after Grid)
  • Stick to track controls (radio buttons vs. checkbox) -- radio buttons use deprecated artwork

@arouinfar
Copy link
Author

arouinfar commented Jun 22, 2022

We should also decide if there are any ESP-only features that would be appropriate to include in the Basics version. For example, the timer and measuring tape may be useful in Basics.

There are also PhET-iO implications to consider. The Studio trees of Geometric Optics and Geometric Optics: Basics are nearly identical and it's possible to essentially turn one sim into the other using PhET-iO, see phetsims/geometric-optics-basics#3. We should decide if the "one API, one Studio tree" approach is appropriate here.

@arouinfar
Copy link
Author

This simulation is not currently a priority, unassigning.

@marlitas
Copy link
Contributor

@kathy-phet should this design update be included in the upcoming publication?

@arouinfar
Copy link
Author

@marlitas is the plan to deploy both ESP and ESPB with the ongoing character set work? Currently, only the full ESP has been published with skater localization. This seems like an excellent opportunity to redeploy Basics and modernize it.

Basics is on an extremely stale branch (circa 2016) and completely predates all work on the full ESP sim. During the development of ESP, we made many changes to Basics but these changes have never been tested or deployed. I've detailed the remaining work to be done earlier in this issue, which is nontrivial but lower complexity.

@marlitas
Copy link
Contributor

Yes. As I understand it ESPB would be redeployed with the new region and culture skaters as well. I'm not sure how much time @kathy-phet wants to put into the redesign, but I assume if there are straightforward aspects it would be beneficial to include them in the redeploy.

@marlitas
Copy link
Contributor

@amanda-phet is the designer I've been working with on this to provide feedback and design support. It might be useful to set up a meeting with the three of us to determine what could be included in this upcoming ESPB publication?

@arouinfar
Copy link
Author

@marlitas @amanda-phet I think it would be good for the three of us to meet and go over ESPB. There are many unpublished changes in that sim, so I don't think it's a good candidate for localization unless we can spend a little time on cleanup too.

@marlitas
Copy link
Contributor

marlitas commented Nov 1, 2023

@arouinfar, @kathy-phet let me know that we should not focus on localization for this sim with so many things up in the air. I've pushed the priority down for this sim, and I imagine it will not be part of the upcoming publications because of that.

@zepumph zepumph changed the title Update design before redeploy from master Update design before redeploy from main Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants