move TODOs, #552

phetsims · May 19, 2023 · 14c2bb8 · 14c2bb8
1 parent b639294
commit 14c2bb8
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 25 deletions.
diff --git a/js/common/view/describers/BothHandsDescriber.ts b/js/common/view/describers/BothHandsDescriber.ts
@@ -64,7 +64,7 @@ class BothHandsDescriber {
       }
     }
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( ratioDistancePositionContextResponsePatternStringProperty, {
       distance: this.handPositionsDescriber.getBothHandsDistance( true, options ),
       position: this.getBothHandsPosition()
@@ -75,7 +75,7 @@ class BothHandsDescriber {
    * Similar to getBothHandsContextResponse, but without extra logic for edges and distance-progress.
    */
   public getBothHandsDynamicDescription(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( ratioDistancePositionContextResponsePatternStringProperty, {
       distance: this.handPositionsDescriber.getBothHandsDistance( true, {
         distanceResponseType: DistanceResponseType.DISTANCE_REGION
@@ -95,7 +95,7 @@ class BothHandsDescriber {
     const leftPosition = this.handPositionsDescriber.getHandPositionDescription( currentTuple.antecedent, tickMarkView );
     const rightPosition = this.handPositionsDescriber.getHandPositionDescription( currentTuple.consequent, tickMarkView );
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     if ( leftPosition === rightPosition ) {
       return StringUtils.fillIn( RatioAndProportionStrings.a11y.bothHands.equalObjectResponseAlertStringProperty, {
         inPosition: leftPosition

diff --git a/js/common/view/describers/HandPositionsDescriber.ts b/js/common/view/describers/HandPositionsDescriber.ts
@@ -30,7 +30,7 @@ import DistanceResponseType from './DistanceResponseType.js';
 import optionize from '../../../../../phet-core/js/optionize.js';
 import RatioInputModality from './RatioInputModality.js';
 
-// TODO: Dynamic string support when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+// TODO: Dynamic string support when time, https://github.com/phetsims/ratio-and-proportion/issues/552
 const DISTANCE_REGIONS_CAPITALIZED = [
   RatioAndProportionStrings.a11y.handPosition.distance.capitalized.farthestFromStringProperty.value,
   RatioAndProportionStrings.a11y.handPosition.distance.capitalized.extremelyFarFromStringProperty.value,
@@ -168,14 +168,14 @@ class HandPositionsDescriber {
 
     // semi quantitative description uses ordinal numbers instead of full numbers.
     if ( semiQuantitative && typeof tickMarkData.ordinalPosition === 'string' ) {
-      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
       return StringUtils.fillIn( RatioAndProportionStrings.a11y.tickMark.semiQuantitativeHandPositionPatternStringProperty, {
         relativePosition: tickMarkData.relativePosition,
         ordinal: tickMarkData.ordinalPosition
       } );
     }
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.tickMark.quantitativeHandPositionPatternStringProperty, {
       relativePosition: tickMarkData.relativePosition,
       tickMarkPosition: tickMarkData.tickMarkPosition
@@ -284,13 +284,13 @@ class HandPositionsDescriber {
                                     RatioAndProportionStrings.a11y.leftHandLowerStringProperty :
                                     RatioAndProportionStrings.a11y.rightHandLowerStringProperty;
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     const distanceResponse = StringUtils.fillIn( RatioAndProportionStrings.a11y.handPosition.distanceOrDistanceProgressClauseStringProperty, {
       otherHand: otherHandStringProperty,
       distanceOrDistanceProgress: distanceClause
     } );
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.ratio.distancePositionContextResponseStringProperty, {
       distance: distanceResponse,
       position: this.getHandPositionDescription( this.ratioTupleProperty.value.getForTerm( ratioTerm ),
@@ -362,7 +362,7 @@ class HandPositionsDescriber {
       fartherString: RatioAndProportionStrings.a11y.handPosition.fartherApartStringProperty.value
     } );
     if ( distanceProgressPhrase ) {
-      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
       return StringUtils.fillIn( RatioAndProportionStrings.a11y.bothHands.handsDistanceProgressPatternStringProperty, {
         distanceProgress: distanceProgressPhrase
       } );
@@ -376,7 +376,7 @@ class HandPositionsDescriber {
     const pattern = capitalized ? RatioAndProportionStrings.a11y.bothHands.handsDistancePatternCapitalizedStringProperty.value :
                     RatioAndProportionStrings.a11y.bothHands.handsDistancePatternStringProperty.value;
 
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( pattern, { distance: distanceRegion } );
   }
 
@@ -392,7 +392,7 @@ class HandPositionsDescriber {
         fartherString: RatioAndProportionStrings.a11y.handPosition.fartherApartStringProperty.value
       } );
       if ( distanceProgressPhrase ) {
-        // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+        // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
         const distanceProgressDescription = StringUtils.fillIn( RatioAndProportionStrings.a11y.bothHands.handsDistanceProgressPatternStringProperty, {
           distanceProgress: distanceProgressPhrase
         } );
@@ -531,7 +531,7 @@ class HandPositionsDescriber {
                                     RatioAndProportionStrings.a11y.ratio.bothHandsGoBeyondEdgeContextResponseStringProperty :
                                     RatioAndProportionStrings.a11y.ratio.singleHandGoBeyondEdgeContextResponseStringProperty;
 
-      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+      // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
       return StringUtils.fillIn( patternStringProperty, {
         position: extremityPosition,
         hand: handAtEdge,

diff --git a/js/common/view/describers/RatioDescriber.ts b/js/common/view/describers/RatioDescriber.ts
@@ -101,21 +101,21 @@ class RatioDescriber {
   }
 
   public getProximityToChallengeRatio(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.ratio.proximityToRatioObjectResponseStringProperty, {
       proximityToRatio: this.getRatioFitness( false )
     } );
   }
 
   public getProximityToNewChallengeRatioSentence(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.ratio.proximityToNewRatioPatternStringProperty, {
       proximity: this.getRatioFitness( false )
     } );
   }
 
   public getCurrentChallengeSentence( antecedent: number, consequent: number ): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.ratio.currentChallengeStringProperty, {
 
       // for consistency with all values, see https://github.com/phetsims/ratio-and-proportion/issues/283
@@ -125,7 +125,7 @@ class RatioDescriber {
   }
 
   public getTargetRatioChangeAlert( antecedent: number, consequent: number ): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.ratio.targetRatioChangedContextResponseStringProperty, {
       proximityToRatio: this.getProximityToNewChallengeRatioSentence(),
       currentChallenge: this.getCurrentChallengeSentence( antecedent, consequent )

diff --git a/js/create/view/CreateScreenSummaryNode.ts b/js/create/view/CreateScreenSummaryNode.ts
@@ -107,7 +107,7 @@ class CreateScreenSummaryNode extends Node {
   }
 
   private getStateOfSim( currentChallenge: TReadOnlyProperty<string> = RatioAndProportionStrings.a11y.create.challengeStringProperty ): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.screenSummaryQualitativeStateOfSimStringProperty, {
       color: BackgroundColorHandler.getCurrentColorRegion( this.ratioFitnessProperty.value, this.inProportionProperty.value ),
       ratioFitness: this.ratioDescriber.getRatioFitness( false ),
@@ -117,14 +117,14 @@ class CreateScreenSummaryNode extends Node {
   }
 
   private getLeftHandState(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.leftHandBulletStringProperty, {
       position: this.handPositionsDescriber.getHandPositionDescription( this.ratioTupleProperty.value.antecedent, this.tickMarkViewProperty.value )
     } );
   }
 
   private getRightHandState(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.rightHandBulletStringProperty, {
       position: this.handPositionsDescriber.getHandPositionDescription( this.ratioTupleProperty.value.consequent, this.tickMarkViewProperty.value )
     } );
@@ -140,7 +140,7 @@ class CreateScreenSummaryNode extends Node {
     const patternStringProperty = this.myChallengeAccordionBox.expandedProperty.value ?
                                   RatioAndProportionStrings.a11y.detailsButtonWithCurrentChallengePatternStringProperty :
                                   RatioAndProportionStrings.a11y.detailsButtonPatternStringProperty;
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( patternStringProperty, {
       stateOfSim: this.getStateOfSim(),
       leftHand: this.getLeftHandState(),

diff --git a/js/create/view/TickMarkRangeComboBoxNode.ts b/js/create/view/TickMarkRangeComboBoxNode.ts
@@ -112,7 +112,7 @@ class TickMarkRangeComboBoxNode extends HBox {
   }
 
   private getContextResponse(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.create.tickMarkRangeContextResponseStringProperty, {
       range: this.tickMarkRangeMap[ this.tickMarkRangeProperty.value ]
     } );

diff --git a/js/discover/view/DiscoverScreenSummaryNode.ts b/js/discover/view/DiscoverScreenSummaryNode.ts
@@ -96,7 +96,7 @@ class DiscoverScreenSummaryNode extends Node {
   }
 
   private getStateOfSim(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.screenSummaryQualitativeStateOfSimStringProperty, {
       color: BackgroundColorHandler.getCurrentColorRegion( this.ratioFitnessProperty.value, this.inProportionProperty.value ),
       ratioFitness: this.ratioDescriber.getRatioFitness( false ),
@@ -106,21 +106,21 @@ class DiscoverScreenSummaryNode extends Node {
   }
 
   private getLeftHandState(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.leftHandBulletStringProperty, {
       position: this.handPositionsDescriber.getHandPositionDescription( this.ratioTupleProperty.value.antecedent, this.tickMarkViewProperty.value )
     } );
   }
 
   private getRightHandState(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.rightHandBulletStringProperty, {
       position: this.handPositionsDescriber.getHandPositionDescription( this.ratioTupleProperty.value.consequent, this.tickMarkViewProperty.value )
     } );
   }
 
   public getDetailsButtonState(): string {
-    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/499
+    // TODO: PatternStringProperty when time, https://github.com/phetsims/ratio-and-proportion/issues/552
     return StringUtils.fillIn( RatioAndProportionStrings.a11y.detailsButtonPatternStringProperty, {
       stateOfSim: this.getStateOfSim(),
       leftHand: this.getLeftHandState(),