Added Discovery to grpc #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@loafoe Can you review? |
loafoe
force-pushed
the
master
branch
2 times, most recently
from
4de4cb4 to
e9507e8
Compare
|
LGTM I rebased upstream and this causes a bunch of conflicts, can you resolve. I think you should still keep the PR in upstream open and updated to get it merged. Otherwise we need to resolve this every time there is a PB change in upstream and we rebase :) |
loafoe
force-pushed
the
master
branch
4 times, most recently
from
3911ff1 to
246547c
Compare
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
8d0ac8b to
2be966f
Compare
Signed-off-by: Koen de Laat <[email protected]>
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
2be966f to
6bbd1ff
Compare
|
@loafoe, please rebase |
loafoe
force-pushed
the
master
branch
2 times, most recently
from
41d6502 to
2919dfd
Compare
koendelaat
force-pushed
the
feature/grpc-discovery
branch
from
cf4ec26 to
6bbd1ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What this PR does / why we need it
Adds Discovery to the grpc API.
Special notes for your reviewer