adjust ephemeral example for job retry

philips-labs · Aug 16, 2024 · 939aebd · 939aebd
1 parent 161e50e
commit 939aebd
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 11 deletions.
diff --git a/examples/default/main.tf b/examples/default/main.tf
@@ -42,7 +42,10 @@ module "runners" {
   #   iops                  = null
   # }]
 
-  # Grab zip files via lambda_download
+  # When not explicitly set lambda zip files are grapped from the module requiring lambda build.
+  # Alternatively you can set the path to the lambda zip files here.
+  #
+  # For example grab zip files via lambda_download
   # webhook_lambda_zip                = "../lambdas-download/webhook.zip"
   # runner_binaries_syncer_lambda_zip = "../lambdas-download/runner-binaries-syncer.zip"
   # runners_lambda_zip                = "../lambdas-download/runners.zip"
@@ -117,11 +120,11 @@ module "runners" {
   }
 
   # enable job_retry feature. Be careful with this feature, it can lead to API rate limits.
-  job_retry = {
-    enable           = true
-    max_attempts     = 1
-    delay_in_seconds = 180
-  }
+  # job_retry = {
+  #   enable           = true
+  #   max_attempts     = 1
+  #   delay_in_seconds = 180
+  # }
 
   # enable metric creation by the control plane (experimental)
   # enable_metrics_control_plane = true

diff --git a/examples/ephemeral/main.tf b/examples/ephemeral/main.tf
@@ -1,6 +1,6 @@
 locals {
   environment = var.environment != null ? var.environment : "ephemeral"
-  aws_region  = "eu-west-1"
+  aws_region  = var.aws_region
 }
 
 resource "random_id" "random" {
@@ -32,10 +32,13 @@ module "runners" {
     webhook_secret = random_id.random.hex
   }
 
-  # Grab the lambda packages from local directory. Must run /.ci/build.sh first
-  webhook_lambda_zip                = "../../lambda_output/webhook.zip"
-  runner_binaries_syncer_lambda_zip = "../../lambda_output/runner-binaries-syncer.zip"
-  runners_lambda_zip                = "../../lambda_output/runners.zip"
+  # When not explicitly set lambda zip files are grapped from the module requiring lambda build.
+  # Alternatively you can set the path to the lambda zip files here.
+  #
+  # For example grab zip files via lambda_download
+  # webhook_lambda_zip                = "../lambdas-download/webhook.zip"
+  # runner_binaries_syncer_lambda_zip = "../lambdas-download/runner-binaries-syncer.zip"
+  # runners_lambda_zip                = "../lambdas-download/runners.zip"
 
   enable_organization_runners = true
   runner_extra_labels         = ["default", "example"]
@@ -93,6 +96,13 @@ module "runners" {
   #   maxReceiveCount     = 50 # 50 retries every 30 seconds => 25 minutes
   #   deadLetterTargetArn = null
   # }
+
+  # Enable beta feature job retry
+  job_retry = {
+    enable           = true
+    max_attempts     = 1
+    delay_in_seconds = 180
+  }
 }
 
 module "webhook_github_app" {

diff --git a/examples/ephemeral/variables.tf b/examples/ephemeral/variables.tf
@@ -13,3 +13,11 @@ variable "environment" {
   type    = string
   default = null
 }
+
+
+variable "aws_region" {
+  description = "AWS region."
+
+  type    = string
+  default = "eu-west-1"
+}